Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D99E2200B61 for ; Tue, 9 Aug 2016 20:07:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D822A160AA5; Tue, 9 Aug 2016 18:07:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2E170160A6B for ; Tue, 9 Aug 2016 20:07:22 +0200 (CEST) Received: (qmail 43400 invoked by uid 500); 9 Aug 2016 18:07:21 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 43379 invoked by uid 99); 9 Aug 2016 18:07:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Aug 2016 18:07:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B0EA5C0B4A for ; Tue, 9 Aug 2016 18:07:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.195 X-Spam-Level: X-Spam-Status: No, score=-3.195 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id KLs4VOpIhWAC for ; Tue, 9 Aug 2016 18:07:19 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id D28855FBA2 for ; Tue, 9 Aug 2016 18:07:18 +0000 (UTC) Received: (qmail 42478 invoked by uid 99); 9 Aug 2016 18:07:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Aug 2016 18:07:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 878AF2CB07C; Tue, 9 Aug 2016 18:07:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1681567031983493923==" MIME-Version: 1.0 Subject: Re: Review Request 49869: ATLAS-991: avoid enforcing required attributes on deleted entities From: David Kantor To: Jeff Hagelberg , David Kantor , atlas , Shwetha GS Date: Tue, 09 Aug 2016 18:07:17 -0000 Message-ID: <20160809180717.1724.64890@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David Kantor X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49869/ X-Sender: David Kantor References: <20160809003629.6951.6483@reviews.apache.org> In-Reply-To: <20160809003629.6951.6483@reviews.apache.org> Reply-To: David Kantor X-ReviewRequest-Repository: atlas archived-at: Tue, 09 Aug 2016 18:07:23 -0000 --===============1681567031983493923== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49869/ ----------------------------------------------------------- (Updated Aug. 9, 2016, 6:07 p.m.) Review request for atlas. Changes ------- Address Shwetha's second review comments. Bugs: ATLAS-991 https://issues.apache.org/jira/browse/ATLAS-991 Repository: atlas Description ------- When deleting entities, avoid enforcing lower bound constraints (i.e. required attributes) on all entities being deleted. Previously, only the entities that were specifically requested for deletion were skipped when enforcing required attributes, but any composite entities that were owned by 'root' deletion candidates were not skipped, causing NullRequiredAttributeException to be thrown unnecessarily. Diffs (updated) ----- repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 8d31c1b079a11291a87569fde6f2cb21d4258ca9 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java e301a00b16ad316a85714cbda4af43d01f11f4ad repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 26ebbb18fd7fea53e1afdcf5ae1ad78eee4bff3b repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 34842c3dc2904b123fecb5087aee357678b00156 repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java cc6026461bcd38b83dde0bcec2e835f5824e894f repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 90bb635126a02cd38c045bd5332499c4481d3751 repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 428846f1bc83dcdb5ed9737294fde67f611f83e8 Diff: https://reviews.apache.org/r/49869/diff/ Testing ------- Ran all unit and integration tests with no regressions. Thanks, David Kantor --===============1681567031983493923==--