Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============5225147210407726892=="
MIME-Version: 1.0
Subject: Re: Review Request 49869: ATLAS-991: avoid enforcing required
 attributes on deleted entities
From: Shwetha GS <sshivalingamurthy@hortonworks.com>
To: atlas <dev@atlas.incubator.apache.org>, David Kantor <dkantor@us.ibm.com>,
 Shwetha GS <sshivalingamurthy@hortonworks.com>
Date: Tue, 09 Aug 2016 08:49:13 -0000
Message-ID: <20160809084913.1723.73562@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Shwetha GS <noreply@reviews.apache.org>
References: <20160809003629.6951.6483@reviews.apache.org>
In-Reply-To: <20160809003629.6951.6483@reviews.apache.org>
Reply-To: Shwetha GS <sshivalingamurthy@hortonworks.com>
archived-at: Tue, 09 Aug 2016 08:49:20 -0000

--===============5225147210407726892==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49869/#review145185
-----------------------------------------------------------


Fix it, then Ship it!


Minor comment. You can make the change and commit. Thanks


repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 476)
<https://reviews.apache.org/r/49869/#comment211345>

    There is no requirement of get() on the returned map. So, this can be just a set<GuidAndVertex> (GuidAndVertex can be renamed to VertexDetails and contain typeName).
    
    GuidAndVertex.equals() can check equals on just guid


- Shwetha GS


On Aug. 9, 2016, 12:36 a.m., David Kantor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49869/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2016, 12:36 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-991
>     https://issues.apache.org/jira/browse/ATLAS-991
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When deleting entities, avoid enforcing lower bound constraints (i.e. required attributes) on all entities being deleted.  Previously, only the entities that were specifically requested for deletion were skipped when enforcing required attributes, but any composite entities that were owned by 'root' deletion candidates were not skipped, causing NullRequiredAttributeException to be thrown unnecessarily.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 8d31c1b079a11291a87569fde6f2cb21d4258ca9 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java e301a00b16ad316a85714cbda4af43d01f11f4ad 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 0a90bda72e90569c1d9d8fdef2c9df9827742874 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 34842c3dc2904b123fecb5087aee357678b00156 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java cc6026461bcd38b83dde0bcec2e835f5824e894f 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 90bb635126a02cd38c045bd5332499c4481d3751 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 8a0a6bc60818c3dd58e12386c55a471de2508b5e 
> 
> Diff: https://reviews.apache.org/r/49869/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit and integration tests with no regressions.
> 
> 
> Thanks,
> 
> David Kantor
> 
>


--===============5225147210407726892==--