atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vimal Sharma <visha...@hortonworks.com>
Subject Re: Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions
Date Tue, 30 Aug 2016 07:02:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51514/#review147267
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java (line 186)
<https://reviews.apache.org/r/51514/#comment214387>

    It would make sense to add the first entity definition to definitionList



webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java (line 203)
<https://reviews.apache.org/r/51514/#comment214386>

    Entity definition of first entity will get repeated since the first one has already been
added in DEFINITION


- Vimal Sharma


On Aug. 30, 2016, 6:32 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51514/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 6:32 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The bug states that the API response only shows one entity definition in the response
of an update/create call wherease the expectation seems to be of getting the entire list of
the entities that were created/updated.
> 
> The fix adds the required capability by the means of a query parameter responseType with
the value as "full", if the API call is made with this extra parameter, the response would
contain an additional field called "definitionList" which is of type JsonArray. If the parameter
is unspecified, the API response remains unaffected.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 82016d0 
> 
> Diff: https://reviews.apache.org/r/51514/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message