atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Kantor <dkan...@us.ibm.com>
Subject Re: Review Request 49869: ATLAS-991: avoid enforcing required attributes on deleted entities
Date Tue, 09 Aug 2016 18:07:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49869/
-----------------------------------------------------------

(Updated Aug. 9, 2016, 6:07 p.m.)


Review request for atlas.


Changes
-------

Address Shwetha's second review comments.


Bugs: ATLAS-991
    https://issues.apache.org/jira/browse/ATLAS-991


Repository: atlas


Description
-------

When deleting entities, avoid enforcing lower bound constraints (i.e. required attributes)
on all entities being deleted.  Previously, only the entities that were specifically requested
for deletion were skipped when enforcing required attributes, but any composite entities that
were owned by 'root' deletion candidates were not skipped, causing NullRequiredAttributeException
to be thrown unnecessarily.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 8d31c1b079a11291a87569fde6f2cb21d4258ca9

  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
e301a00b16ad316a85714cbda4af43d01f11f4ad 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 26ebbb18fd7fea53e1afdcf5ae1ad78eee4bff3b

  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
34842c3dc2904b123fecb5087aee357678b00156 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java
cc6026461bcd38b83dde0bcec2e835f5824e894f 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java
90bb635126a02cd38c045bd5332499c4481d3751 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 428846f1bc83dcdb5ed9737294fde67f611f83e8


Diff: https://reviews.apache.org/r/49869/diff/


Testing
-------

Ran all unit and integration tests with no regressions.


Thanks,

David Kantor


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message