atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 50823: ATLAS-1096 HiveMetStoreBridge to use getEntity instead of DSL
Date Fri, 05 Aug 2016 06:08:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50823/#review144873
-----------------------------------------------------------


Fix it, then Ship it!




will address these comments and commit


addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java (line
154)
<https://reviews.apache.org/r/50823/#comment211003>

    shouldn't ignore all exceptions, ignore only if 'not found' status



addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
(line 100)
<https://reviews.apache.org/r/50823/#comment211008>

    Add an IT in HiveMetastoreBridgeIT which tests de-duping


- Shwetha GS


On Aug. 5, 2016, 4:29 a.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50823/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 4:29 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1096
>     https://issues.apache.org/jira/browse/ATLAS-1096
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Changed all searchDSL calls to getEntity by qualifiedName and typeName which will use
indexes. 
> Also fixed a minor issue with table qualifiedName in case of importTable
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
8d24a67 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
f8aa93a 
> 
> Diff: https://reviews.apache.org/r/50823/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message