Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============1826396774262491386=="
MIME-Version: 1.0
Subject: Re: Review Request 49636: ATLAS-990 - Hive Import metadata script
 fails with auth exception.
From: Madhan Neethiraj <madhan@apache.org>
To: Hemanth Yamijala <yhemanth@gmail.com>, Mehul Parikh <xsmehul@gmail.com>,
 Madhan Neethiraj <madhan@apache.org>,
 Shwetha GS <sshivalingamurthy@hortonworks.com>
Cc: atlas <dev@atlas.incubator.apache.org>,
 Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
Date: Thu, 07 Jul 2016 06:04:52 -0000
Message-ID: <20160707060452.17622.9341@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Madhan Neethiraj <noreply@reviews.apache.org>
References: <20160705142523.17622.84729@reviews.apache.org>
In-Reply-To: <20160705142523.17622.84729@reviews.apache.org>
Reply-To: Madhan Neethiraj <madhan@apache.org>
archived-at: Thu, 07 Jul 2016 06:04:58 -0000

--===============1826396774262491386==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49636/#review141134
-----------------------------------------------------------


Fix it, then Ship it!


webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java (line 516)
<https://reviews.apache.org/r/49636/#comment206547>

    Remove this and other info logs in the method.


- Madhan Neethiraj


On July 5, 2016, 2:25 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49636/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 2:25 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-990
>     https://issues.apache.org/jira/browse/ATLAS-990
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Changes include fix for authentication failing while hive import script.
> 
> The getToken method was throwing nullpointer exception, so overriden the getToken method and added NPE check do fix it.
> 
> 2016-07-04 14:13:58,946 ERROR - [qtp817406040-17:] ~ Exception in AtlasAuthenticationFilter  (AtlasAuthenticationFilter:304)
> java.lang.NullPointerException
> 	at org.apache.hadoop.security.authentication.server.AuthenticationFilter.getToken(AuthenticationFilter.java:480)
> 	at org.apache.atlas.web.filters.AtlasAuthenticationFilter.doKerberosAuth(AtlasAuthenticationFilter.java:339)
> 	at org.apache.atlas.web.filters.AtlasAuthenticationFilter.doFilter(AtlasAuthenticationFilter.java:299)
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/security/SecureClientUtils.java 1686112 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 1b70e9b 
> 
> Diff: https://reviews.apache.org/r/49636/diff/
> 
> 
> Testing
> -------
> 
> Ran Quick start after kinit and worked fine and example data was populated.
> Ran import hive script after kinit and hive tables schema details was seen.
> Browsed Atlas UI with fqdn url in firefox after kinit without going through login page. 
> 
> Instance http://172.22.107.229:8080/
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


--===============1826396774262491386==--