Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============9167401760656263121=="
MIME-Version: 1.0
Subject: Re: Review Request 49084: ATLAS-584 : Integrate CSRF prevention filter
From: Madhan Neethiraj <madhan@apache.org>
To: Madhan Neethiraj <madhan@apache.org>, Hemanth Yamijala <yhemanth@gmail.com>,
 Gautam Borad <gborad@gmail.com>,
 Shwetha GS <sshivalingamurthy@hortonworks.com>
Cc: keval bhatt <keval.bhatt@freestoneinfotech.com>,
 atlas <dev@atlas.incubator.apache.org>
Date: Wed, 06 Jul 2016 06:21:50 -0000
Message-ID: <20160706062150.17622.9789@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Madhan Neethiraj <noreply@reviews.apache.org>
References: <20160627052343.24741.2679@reviews.apache.org>
In-Reply-To: <20160627052343.24741.2679@reviews.apache.org>
Reply-To: Madhan Neethiraj <madhan@apache.org>
archived-at: Wed, 06 Jul 2016 06:21:57 -0000

--===============9167401760656263121==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49084/#review140957
-----------------------------------------------------------


Fix it, then Ship it!


webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java (line 75)
<https://reviews.apache.org/r/49084/#comment206335>

    Replace '+e.getMessage()' with ', e' so that the error log  will include the stack.


- Madhan Neethiraj


On June 27, 2016, 5:23 a.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49084/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 5:23 a.m.)
> 
> 
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-584
>     https://issues.apache.org/jira/browse/ATLAS-584
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas needs to provide protection for CSRF protection. Need to add CSRF prevention headers to all API calls from UI.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/collection/BaseCollection.js 0c148ac 
>   dashboardv2/public/js/main.js 95f64a1 
>   dashboardv2/public/js/models/BaseModel.js da96d04 
>   dashboardv2/public/js/utils/CommonViewFunction.js ffffa1c 
>   dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js 8fa436c 
>   dashboardv2/public/js/views/site/Header.js 467cbf5 
>   distro/src/conf/atlas-application.properties 79a4982 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a46068 
>   webapp/src/main/resources/spring-security.xml c21a644 
>   webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49084/diff/
> 
> 
> Testing
> -------
> 
> Manual basic testing done for crud operation of Tags,Terms and Taxonomy from UI.
> 
> Ran mvn clean install.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


--===============9167401760656263121==--