atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 49625: ATLAS-347 Atlas search APIs should allow pagination of results
Date Wed, 20 Jul 2016 03:42:27 GMT


> On July 19, 2016, 5:34 p.m., Suma Shivaprasad wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java,
line 221
> > <https://reviews.apache.org/r/49625/diff/3/?file=1447345#file1447345line221>
> >
> >     constants for default limit and offset?

Used only once, so skipped it


> On July 19, 2016, 5:34 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/discovery/DiscoveryService.java, line
29
> > <https://reviews.apache.org/r/49625/diff/3/?file=1447355#file1447355line29>
> >
> >     didnt understand why this was removed from server-api?

Moved to repository as the interface requires QueryParams which is in repository


- Shwetha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49625/#review142770
-----------------------------------------------------------


On July 19, 2016, 4:45 p.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49625/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 4:45 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-347
>     https://issues.apache.org/jira/browse/ATLAS-347
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1. orderby doesn't require fully qualified field name anymore. For example, 'hive_table
orderby name' resolves name to Asset.name
> 2. Added limit and offset to search by DSL API.
> 3. DSL query adds API's limit and offset to the specified DSL query. For eaxmple, 'hive_table
orderby name' maps to 'hive_table orderby name limit 100 offset 0'. 'hive_table orderby name
limit 200 offset 10' maps to 'hive_table orderby name limit 100 offset 10'. 100 and 0 are
API's limit and offset respectively here
> 4. All existing tests work
> 
> Pending:
> 1. Add more tests 
> 2. Add limit and offset for full text search. I don't think the index search that we
do supports pagination. May have to filter results on atlas server
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
9a5e279 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
9f7f6b0 
>   addons/sqoop-bridge/src/test/java/org/apache/atlas/sqoop/hook/SqoopHookIT.java e965c7d

>   addons/storm-bridge/src/test/java/org/apache/atlas/storm/hook/StormAtlasHookIT.java
b33bb5f 
>   client/src/main/java/org/apache/atlas/AtlasClient.java d3af6ad 
>   common/src/main/java/org/apache/atlas/AtlasProperties.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/utils/ParamChecker.java edfe355 
>   docs/src/site/twiki/Configuration.twiki 3ad0fbe 
>   docs/src/site/twiki/Search.twiki 58c9238 
>   repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java c6790de

>   repository/src/main/java/org/apache/atlas/discovery/DiscoveryService.java PRE-CREATION

>   repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
e07a54e 
>   repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
6def78b 
>   repository/src/main/java/org/apache/atlas/repository/Constants.java 893f1b6 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala ab7e81c 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala d76b173 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 60b57d9 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 5fc9400 
>   repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala 5a64c53 
>   repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java
89e9b41 
>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
c27894e 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
97dfbcd 
>   repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java f2a5b50

>   server-api/src/main/java/org/apache/atlas/discovery/DiscoveryService.java e347c2c 
>   webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java 7173d4d 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 42bccec 
>   webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java
256f7d3 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
72f403e 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 498db92 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java d41041c

>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java
a8c1213 
> 
> Diff: https://reviews.apache.org/r/49625/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message