atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 49941: ATLAS-998: determine HA mode from property atlas.server.ids, instead of atlas.server.ha.enabled
Date Wed, 13 Jul 2016 07:28:10 GMT


> On July 12, 2016, 5:52 a.m., Shwetha GS wrote:
> > common/src/main/java/org/apache/atlas/ha/HAConfiguration.java, line 65
> > <https://reviews.apache.org/r/49941/diff/1/?file=1441953#file1441953line65>
> >
> >     To make it backward compatible, as 0.7 is already out, can the check be if ha.enabled
or ids > 1?
> 
> Madhan Neethiraj wrote:
>     The fix is to remove 'ha.enabled' property. Instead of keeping it for backward compatibility,
I would suggest to document the removal of this property in the next release notes.

The fix is to use ids property to enable HA. For someone upgrading, all these are manual changes
and add to upgrade checklist and its better to minimise if possible.

Can you update docs/src/site/twiki/HighAvailability.twiki? 

Its difficult to compile this list during release. Can you create upgrade.twiki under docs/src/site/twiki/
and add to it?


- Shwetha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49941/#review141855
-----------------------------------------------------------


On July 13, 2016, 6:20 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49941/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 6:20 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-998
>     https://issues.apache.org/jira/browse/ATLAS-998
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated to use atlas.server.ids property to determine if multiple instances of Atlas
are configured to run (in HA mode), instead of atlas.server.ha.enabled
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/ha/HAConfiguration.java f3c9bc5 
>   common/src/test/java/org/apache/atlas/ha/HAConfigurationTest.java a3129c9 
>   repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryHATest.java
2f7edb4 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java
94dd298 
>   repository/src/test/java/org/apache/atlas/services/DefaultMetadataServiceMockTest.java
393b539 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
7860eb6 
>   webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java
2b7691f 
>   webapp/src/test/java/org/apache/atlas/web/service/ServiceStateTest.java 77aba88 
> 
> Diff: https://reviews.apache.org/r/49941/diff/
> 
> 
> Testing
> -------
> 
> - Verified that all unit tests succeed
> - Verified that when multiple instances are listed in 'atlas.server.ids' configuration,
Atlas server takes HA code path
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message