atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Kantor <dkan...@us.ibm.com>
Subject Re: Review Request 49869: ATLAS-991: avoid enforcing required attributes on deleted entities
Date Tue, 12 Jul 2016 22:24:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49869/
-----------------------------------------------------------

(Updated July 12, 2016, 10:24 p.m.)


Review request for atlas.


Bugs: ATLAS-991
    https://issues.apache.org/jira/browse/ATLAS-991


Repository: atlas


Description
-------

When deleting entities, avoid enforcing lower bound constraints (i.e. required attributes)
on all entities being deleted.  Previously, only the entities that were specifically requested
for deletion were skipped when enforcing required attributes, but any composite entities that
were owned by 'root' deletion candidates were not skipped, causing NullRequiredAttributeException
to be thrown unnecessarily.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 91f9bd008a6939dfe78656f5c1845637a30ee9eb

  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
e5c0e46e2ed1d9e0be987c30b9a0613784c82627 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 4f531e28173f79d63dc3642f2aedd69df2fa12a6

  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
34842c3dc2904b123fecb5087aee357678b00156 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java
cc6026461bcd38b83dde0bcec2e835f5824e894f 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java
90bb635126a02cd38c045bd5332499c4481d3751 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/49869/diff/


Testing
-------

Ran all unit and integration tests with no regressions.


Thanks,

David Kantor


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message