atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Hagelberg <jnhagelb...@us.ibm.com>
Subject Re: Review Request 49929: ATLAS-1003: ensure tests cleanup graph to avoid leaving data that affects downstream tests
Date Tue, 12 Jul 2016 19:34:37 GMT


> On July 12, 2016, 7:34 p.m., Jeff Hagelberg wrote:
> > Ship It!

Thanks Dave.  This seems fine to me.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49929/#review141953
-----------------------------------------------------------


On July 12, 2016, 2:55 p.m., David Kantor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49929/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 2:55 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1003
>     https://issues.apache.org/jira/browse/ATLAS-1003
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1003: Ignore exception from TitanGraph.shutdown() and continue processing TitanCleanup.clear()
to ensure tests don't leave data in the graph that could cause problems for subsequent tests.
 Previously, some tests would fail depending on the order that the maven surefire plugin executed
the tests, due to type data left over in the graph store from a previous test.
> 
> 
> Diffs
> -----
> 
>   repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
da47dc1b90322189e3129ed8e4185a832bc49678 
>   repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java
4cb5c678f0f530f2c1ef517f3a4fb5d8b4f4fb37 
>   repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala b23c0f60ace59fa15886c94f35e35d3113872783

>   repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 0e0ac8633a256dc7c8966c2b8d52eb942b52e1c6

> 
> Diff: https://reviews.apache.org/r/49929/diff/
> 
> 
> Testing
> -------
> 
> All repository tests now pass, regardless of test order.
> 
> 
> Thanks,
> 
> David Kantor
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message