Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4CC7F200B13 for ; Wed, 15 Jun 2016 19:36:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4B207160A4D; Wed, 15 Jun 2016 17:36:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 953A5160A19 for ; Wed, 15 Jun 2016 19:36:16 +0200 (CEST) Received: (qmail 61208 invoked by uid 500); 15 Jun 2016 17:36:15 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 61197 invoked by uid 99); 15 Jun 2016 17:36:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jun 2016 17:36:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 273BE1A05A6 for ; Wed, 15 Jun 2016 17:36:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.195 X-Spam-Level: X-Spam-Status: No, score=-3.195 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id SFehfK2WTg6B for ; Wed, 15 Jun 2016 17:36:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 996E45FACC for ; Wed, 15 Jun 2016 17:36:13 +0000 (UTC) Received: (qmail 61189 invoked by uid 99); 15 Jun 2016 17:36:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jun 2016 17:36:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 314D72C5CEC; Wed, 15 Jun 2016 17:36:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6123548290272097799==" MIME-Version: 1.0 Subject: Re: Review Request 48565: ATLAS-856: lazy-load type cache provider From: venkata madugundu To: David Kantor , atlas , venkata madugundu Date: Wed, 15 Jun 2016 17:36:12 -0000 Message-ID: <20160615173612.30691.90268@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: venkata madugundu X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/48565/ In-Reply-To: <20160615150555.14973.29641@reviews.apache.org> X-Sender: venkata madugundu X-ReviewBoard-ShipIt: 1 References: <20160615150555.14973.29641@reviews.apache.org> X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheProvider.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheProviderTest.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: venkata madugundu X-ReviewRequest-Repository: atlas archived-at: Wed, 15 Jun 2016 17:36:17 -0000 --===============6123548290272097799== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48565/#review137778 ----------------------------------------------------------- Ship it! Ship It! - venkata madugundu On June 15, 2016, 3:05 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48565/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 3:05 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-856 > https://issues.apache.org/jira/browse/ATLAS-856 > > > Repository: atlas > > > Description > ------- > > ATLAS-856: An extension of DefaultTypeCacheProvider which loads the requested type from the type store if it is not found in the cache, and adds it to the cache if it's found in the store. Any attribute and super types that are required by the requested type are also loaded from the store if they are not already in the cache. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 5ed9e02eb85ec25b63540cab40d148914d410786 > repository/src/main/java/org/apache/atlas/repository/typestore/ITypeStore.java 790c4b31c37e51289585f6f891366a8d8c86b168 > repository/src/main/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheProvider.java PRE-CREATION > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 961442bbcaff86b472a876e6c348aa9e65c1efca > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheProviderTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/48565/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > > --===============6123548290272097799==--