atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ATLAS QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-911) Get entity by unique attribute doesn't enforce type
Date Fri, 17 Jun 2016 05:26:05 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335438#comment-15335438
] 

ATLAS QA commented on ATLAS-911:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12811280/ATLAS-911.patch
  against master revision c9ee6d3.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 380 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/315//console

This message is automatically generated.

> Get entity by unique attribute doesn't enforce type
> ---------------------------------------------------
>
>                 Key: ATLAS-911
>                 URL: https://issues.apache.org/jira/browse/ATLAS-911
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>            Priority: Critical
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-911.patch
>
>
> Currently, get entity by unique attribute just filters on the attribute property. Since
the attribute name contains the typename as well, type filter was not added. But if multiple
types have the same super type, and the super type has the unique attribute, the attribute
name will be same for multiple types. With this, the type returned will not be same as the
type requested.
> We should add filter on the type as well



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message