atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ATLAS QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-431) Remove un-used licenses
Date Tue, 28 Jun 2016 09:26:57 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352659#comment-15352659
] 

ATLAS QA commented on ATLAS-431:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12814066/ATLAS-431.patch
  against master revision 0bf878d.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 380 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest

Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/372//console

This message is automatically generated.

> Remove un-used licenses
> -----------------------
>
>                 Key: ATLAS-431
>                 URL: https://issues.apache.org/jira/browse/ATLAS-431
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-431.patch
>
>
> From 0.6 voting thread:
> On 26/12/15 5:14 am, "Justin Mclean" <justin@classsoftware.com> wrote:
> Hi,
> +1 binding
> I checked:
> - artefact contains “incubating”
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE and NOTICE good, but license main contain too many things (see below).
> - no unexpected binaries in release
> - all source files have Apache headers
> - can compile from source
> The license mentions Berkeley DB Java Edition and ASM but it doesn’t look like these
are bundled in the source release. If this is the case they should be removed from the source
LICENSE file. [1]
> Thanks,
> Justin
> 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message