atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 48565: ATLAS-856: lazy-load type cache provider
Date Fri, 17 Jun 2016 18:37:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48565/#review138278
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheProvider.java
(line 205)
<https://reviews.apache.org/r/48565/#comment203457>

    this should have handled NOT_FOUND. So, throwing exception from getTypeFromCacheOrStore()
will work in all cases


- Shwetha GS


On June 15, 2016, 3:05 p.m., David Kantor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48565/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 3:05 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-856
>     https://issues.apache.org/jira/browse/ATLAS-856
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-856: An extension of DefaultTypeCacheProvider which loads the requested type from
the type store if it is not found in the cache,  and adds it to the cache if it's found in
the store.  Any attribute and super types that are required by the requested type are also
loaded from the store if they are not already in the cache.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
5ed9e02eb85ec25b63540cab40d148914d410786 
>   repository/src/main/java/org/apache/atlas/repository/typestore/ITypeStore.java 790c4b31c37e51289585f6f891366a8d8c86b168

>   repository/src/main/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheProvider.java
PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
961442bbcaff86b472a876e6c348aa9e65c1efca 
>   repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheProviderTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48565/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit and integration tests with no regressions.
> 
> 
> Thanks,
> 
> David Kantor
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message