atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hemanth Yamijala <yhema...@gmail.com>
Subject Re: Review Request 48845: ATLAS-835 Falcon Integration with Atlas
Date Fri, 17 Jun 2016 12:03:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48845/#review138203
-----------------------------------------------------------




addons/storm-bridge/pom.xml (line 102)
<https://reviews.apache.org/r/48845/#comment203420>

    Why this change? These dependency changes might need to be tested in the host component
environments. Also, I see we have a dependency exclusion when specifying storm dependency
pointing to slf4j-log4j12, should that change?



distro/src/conf/atlas-log4j.xml (line 47)
<https://reviews.apache.org/r/48845/#comment203421>

    This was purposefully fixed in ATLAS-867 to be INFO. Maybe we should leave it that way.



notification/src/main/java/org/apache/atlas/hook/AtlasHook.java (line 118)
<https://reviews.apache.org/r/48845/#comment203422>

    This check seems to be causing AtlasHookTest to fail - can you please take a look. Mostly
the test will need fixing.


- Hemanth Yamijala


On June 17, 2016, 10:47 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48845/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 10:47 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-835
>     https://issues.apache.org/jira/browse/ATLAS-835
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Falcon Integration with Atlas
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java PRE-CREATION

>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
PRE-CREATION 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java PRE-CREATION

>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java f27a8b0

>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
397dea4 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataTypes.java
f1f350b 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/publisher/FalconEventPublisher.java
PRE-CREATION 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
PRE-CREATION 
>   addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/Util/EventUtil.java 7f67407

>   addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/event/FalconEvent.java e587e73

>   addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/publisher/FalconEventPublisher.java
8029be9 
>   addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/service/AtlasService.java
373846d 
>   addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 7adccef

>   addons/falcon-bridge/src/test/resources/feed-replication.xml PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 0ccb18b 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 00c17e8

>   addons/storm-bridge/pom.xml b1a7a9b 
>   distro/src/conf/atlas-log4j.xml 600b4f1 
>   docs/src/site/twiki/Bridge-Falcon.twiki 4f5e676 
>   notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 2ca8d85 
>   pom.xml 6f75740 
>   typesystem/src/main/resources/atlas-application.properties 11253e6 
>   typesystem/src/main/resources/atlas-log4j.xml 2bb49d3 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java eeaddd6 
> 
> Diff: https://reviews.apache.org/r/48845/diff/
> 
> 
> Testing
> -------
> 
> UTs and end to end test
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message