atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Hagelberg <jnhagelb...@us.ibm.com>
Subject Re: Review Request 48349: ATLAS-871: Add mechanism to disable HBaseBasedEntityAuditRepository
Date Thu, 09 Jun 2016 15:06:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48349/
-----------------------------------------------------------

(Updated June 9, 2016, 3:06 p.m.)


Review request for atlas and David Kantor.


Changes
-------

Addressed code review comments from Shweta.


Bugs: ATLAS-871
    https://issues.apache.org/jira/browse/ATLAS-871


Repository: atlas


Description
-------

This task adds the ability to disable the HBaseBasedEntityAuditRepository and use Atlas in
environments where hbase is not available.  This is needed because some graph database implementations
do not use or support hbase.  It also makes development easier in environments where hbase
is not available.

This task does the following:
  - add new optional configuration property to specify the audit repository implementation
  - adds new NoopEntityAuditRepository that can be used in environments where a suitable EntityAuditRepository
has not been implemented yet (or where there is not an auditing requirement)
  - Updates atlas_start.py so that it does not fail if hbase is not selected.
  - Updated DefaultMetadataServiceTest so that the tests unrelated to hbase pass if hbase
is not available.


Diffs (updated)
-----

  distro/pom.xml 131a4882f4728f5c9df8a50e283463f8aa35ddbd 
  distro/src/bin/atlas_start.py 1ba38f8683c4274475fd097ff182c5cfa8db1dd4 
  distro/src/conf/atlas-application.properties 1cdd424d8e126a6bdbf99db8bf4e5d4329e806bb 
  pom.xml eac95c8526011a3a86de8dd154545abec0f7bcf5 
  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 15201dd45913539b9b3bd430b46ce6cf30c327ac

  repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
93f224fa01c494e5765ccbdb691aa950111a8c20 
  repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
PRE-CREATION 
  typesystem/src/main/resources/atlas-application.properties 3318ff306a8b8ab5e320129a8450d144215f009f


Diff: https://reviews.apache.org/r/48349/diff/


Testing
-------

Ran Atlas build and integration tests, no regressions found.


Thanks,

Jeff Hagelberg


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message