Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AAE9E2009F4 for ; Thu, 26 May 2016 21:15:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A9B13160A18; Thu, 26 May 2016 19:15:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F1B20160A17 for ; Thu, 26 May 2016 21:15:04 +0200 (CEST) Received: (qmail 89786 invoked by uid 500); 26 May 2016 19:15:04 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 89775 invoked by uid 99); 26 May 2016 19:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 May 2016 19:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6D42A18065F for ; Thu, 26 May 2016 19:15:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.02 X-Spam-Level: X-Spam-Status: No, score=-2.02 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id G2JzF2JEyoYH for ; Thu, 26 May 2016 19:15:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 3EBDA5F46D for ; Thu, 26 May 2016 19:15:00 +0000 (UTC) Received: (qmail 89681 invoked by uid 99); 26 May 2016 19:14:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 May 2016 19:14:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 42B8E2C367A; Thu, 26 May 2016 19:14:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6075080356303986740==" MIME-Version: 1.0 Subject: Re: Review Request 47782: Atlas should use external HBase and SOLR From: Tom Beerbower To: Hemanth Yamijala Cc: Madhan Neethiraj , Tom Beerbower , atlas , Shwetha GS Date: Thu, 26 May 2016 19:14:59 -0000 Message-ID: <20160526191459.1683.29041@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Tom Beerbower X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/47782/ X-Sender: Tom Beerbower References: <20160526180413.1682.94170@reviews.apache.org> In-Reply-To: <20160526180413.1682.94170@reviews.apache.org> Reply-To: Tom Beerbower X-ReviewRequest-Repository: atlas archived-at: Thu, 26 May 2016 19:15:05 -0000 --===============6075080356303986740== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 26, 2016, 6:04 p.m., Shwetha GS wrote: > > distro/src/conf/hbase_solr-atlas-application.properties, line 2 > > > > > > Instead of adding new files, where configs can go out of sync. Can you use single file and use resource filtering to populate the values correctly. Have added ATLAS-823-modified.patch on the jira, check if it makes sense > > Tom Beerbower wrote: > Yeah, the replacement values is better. One question with that... since you are specifying the values for both profiles (dist and embedded_services) which one wins if both profiles are used for the build? Should the default values (berkeley, elasticsearch) be specified at a global level and then just overridden for the embedded_services profile? I'll try it out and update the patch. Thanks. Updated diff to included changes from your patch. Thanks. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47782/#review135028 ----------------------------------------------------------- On May 26, 2016, 7:14 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47782/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 7:14 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-823 > https://issues.apache.org/jira/browse/ATLAS-823 > > > Repository: atlas > > > Description > ------- > > Use of embedded HBase and SOLR is not preferred due to multiple concerns, including: > > 1. lack of support by Ambari makes it difficult to handle kerberization, upgrade/migration, start/stop > 2. not suitable for production use - no HA, local-storage > > Atlas should remove support for embedded HBase and SOLR. Instead Atlas should be updated to use external HBase and SOLR. > > > Diffs > ----- > > distro/pom.xml 1ab092d > distro/src/bin/atlas_config.py 8f3479c > distro/src/bin/atlas_start.py cb869bb > distro/src/conf/atlas-application.properties 26f84e9 > distro/src/conf/atlas-env.sh 4f1f46c > distro/src/main/assemblies/standalone-package.xml 09ff47d > docs/src/site/twiki/Configuration.twiki 879c06c > docs/src/site/twiki/InstallationSteps.twiki 006e1e8 > > Diff: https://reviews.apache.org/r/47782/diff/ > > > Testing > ------- > > updated unit test > > mvn clean test > > > Thanks, > > Tom Beerbower > > --===============6075080356303986740==--