Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5C0A62009A8 for ; Tue, 17 May 2016 17:12:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5A6A91609F5; Tue, 17 May 2016 15:12:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F2C091607A8 for ; Tue, 17 May 2016 17:12:29 +0200 (CEST) Received: (qmail 41450 invoked by uid 500); 17 May 2016 15:12:26 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 41135 invoked by uid 99); 17 May 2016 15:12:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 May 2016 15:12:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 27D24C0CD5 for ; Tue, 17 May 2016 15:12:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.819 X-Spam-Level: X-Spam-Status: No, score=-0.819 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id YZepse--iOqW for ; Tue, 17 May 2016 15:12:25 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 7B2975F485 for ; Tue, 17 May 2016 15:12:24 +0000 (UTC) Received: (qmail 41120 invoked by uid 99); 17 May 2016 15:12:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 May 2016 15:12:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A556C2BADC4; Tue, 17 May 2016 15:12:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2475359682769518811==" MIME-Version: 1.0 Subject: Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled. From: Suma Shivaprasad To: atlas , Shwetha GS Date: Tue, 17 May 2016 15:12:22 -0000 Message-ID: <20160517151222.25691.67422@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/47225/ In-Reply-To: <20160517081533.8624.39383@reviews.apache.org> X-Sender: Suma Shivaprasad X-ReviewBoard-ShipIt: 1 References: <20160517081533.8624.39383@reviews.apache.org> X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas archived-at: Tue, 17 May 2016 15:12:31 -0000 --===============2475359682769518811== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47225/#review133548 ----------------------------------------------------------- Ship it! Ship It! - Suma Shivaprasad On May 17, 2016, 8:15 a.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47225/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 8:15 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-713 > https://issues.apache.org/jira/browse/ATLAS-713 > > > Repository: atlas > > > Description > ------- > > Current lineage APIs work on the dataset name. With soft delete, there can be more than one entities for the given dataset name. > 1. Added new lineage APIs(input graph, output graph, schema) which work on entity id > 2. Modified current lineage APIs to work on the active entity for the given dataset name > 3. Modified UI to use the new APIs > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c > dashboardv2/public/js/models/VLineage.js e33488a > dashboardv2/public/js/models/VSchema.js 1f8e0bb > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 > dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 > dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 > distro/src/conf/atlas-application.properties 68a0021 > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8dae968 > repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java PRE-CREATION > repository/src/main/java/org/apache/atlas/discovery/HiveLineageService.java 00905d7 > repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 05dc6a4 > repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 66e1365 > repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java PRE-CREATION > repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java PRE-CREATION > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 3b50dfb > repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java 6d5a15a > repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 2fd8bb9 > server-api/src/main/java/org/apache/atlas/discovery/LineageService.java 8dc36cd > typesystem/src/main/resources/atlas-application.properties aafad0f > webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/resources/HiveLineageResource.java 9b3fbc9 > webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java PRE-CREATION > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java PRE-CREATION > webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java bc02f90 > > Diff: https://reviews.apache.org/r/47225/diff/ > > > Testing > ------- > > UTs, ITs and end to end test with hive cli > > > Thanks, > > Shwetha GS > > --===============2475359682769518811==--