Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3216375045117905976=="
MIME-Version: 1.0
Subject: Re: Review Request 46699: ATLAS-661 :  Rest API Authentication.
From: Selvamohan Neethiraj <sneethiraj@hortonworks.com>
To: Hemanth Yamijala <yhemanth@gmail.com>,
 Velmurugan Periasamy <vperiasamy@hortonworks.com>,
 Larry McCay <lmccay@apache.org>,
 Selvamohan Neethiraj <sneethiraj@hortonworks.com>,
 Erik Bergenholtz <ebergenholtz@hortonworks.com>,
 Madhan Neethiraj <madhan@apache.org>,
 Shwetha GS <sshivalingamurthy@hortonworks.com>
Cc: atlas <dev@atlas.incubator.apache.org>,
 Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
Date: Fri, 06 May 2016 14:30:40 -0000
Message-ID: <20160506143040.1838.10181@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Selvamohan Neethiraj <noreply@reviews.apache.org>
References: <20160506062437.1837.87425@reviews.apache.org>
In-Reply-To: <20160506062437.1837.87425@reviews.apache.org>
Reply-To: Selvamohan Neethiraj <sneethiraj@hortonworks.com>
archived-at: Fri, 06 May 2016 14:30:47 -0000

--===============3216375045117905976==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46699/#review132033
-----------------------------------------------------------


Ship it!


Installed standalone atlas webserver. Verified REST api accesses with no Basic auth, wrong cred and valid cred. Works as expected.

- Selvamohan Neethiraj


On May 6, 2016, 2:24 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46699/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 2:24 a.m.)
> 
> 
> Review request for atlas, Erik Bergenholtz, Larry McCay, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, Suma Shivaprasad, Velmurugan Periasamy, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-661
>     https://issues.apache.org/jira/browse/ATLAS-661
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Introduced Rest API Authentication.
> Introduced role and encoded password in user-credential file.
> Authentication to fall back to file type if LDAP fails.
> Changes in quick_start.py, atlas_admin.py & import_hive.sh to take password argument for basic authentication
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5 
>   client/src/main/java/org/apache/atlas/AtlasAdminClient.java 473f72a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java be34802 
>   common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java PRE-CREATION 
>   dashboardv2/public/js/utils/Utils.js 7b2db79 
>   distro/src/conf/users-credentials.properties 94e7cf4 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124 
>   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 76784c4 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationEntryPoint.java b77bd28 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java 96dca45 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b2b11da 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java 7f87bd5 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java b3e3354 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java d911c1b 
>   webapp/src/main/resources/atlas-admin-site.xml ab8ba3d 
>   webapp/src/main/resources/spring-security.xml 8533473 
>   webapp/src/main/webapp/WEB-INF/web.xml deb97d9 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92 
>   webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 7e4c2c8 
>   webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java 9aac32a 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 2be52e7 
>   webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 5b5c70e 
> 
> Diff: https://reviews.apache.org/r/46699/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done.
> performed mvn clean install
> performed mvn clean package -Pdist
> 
> Found Failed tests: 
>   HiveLineageJerseyResourceIT.setUp:52->setupInstances:169->table:234->BaseResourceIT.createInstance:129 » AtlasService
>   
> Tests run: 10, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 22.476 sec <<< FAILURE! - in org.apache.atlas.repository.graph.GraphBackedRepositoryHardDeleteTest
> testDisconnectBidirectionalReferences(org.apache.atlas.repository.graph.GraphBackedRepositoryHardDeleteTest)  Time elapsed: 0.566 sec  <<< FAILURE!
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


--===============3216375045117905976==--