Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============7296954189700038003=="
MIME-Version: 1.0
Subject: Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates
 new AtlasClient for every message
From: Hemanth Yamijala <yhemanth@gmail.com>
To: Hemanth Yamijala <yhemanth@gmail.com>,
 atlas <dev@atlas.incubator.apache.org>,
 Shwetha GS <sshivalingamurthy@hortonworks.com>
Date: Fri, 06 May 2016 06:49:55 -0000
Message-ID: <20160506064955.1837.65734@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Hemanth Yamijala <noreply@reviews.apache.org>
References: <20160505103210.2047.94261@reviews.apache.org>
In-Reply-To: <20160505103210.2047.94261@reviews.apache.org>
Reply-To: Hemanth Yamijala <yhemanth@gmail.com>
archived-at: Fri, 06 May 2016 06:50:02 -0000

--===============7296954189700038003==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46650/#review131990
-----------------------------------------------------------


Fix it, then Ship it!


Mostly fine - very minor nits to take care of. Also, .gitignore file has a merge conflict due to ATLAS-742


.gitignore (line 51)
<https://reviews.apache.org/r/46650/#comment196027>

    Missing closing brackets


- Hemanth Yamijala


On May 5, 2016, 10:32 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46650/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 10:32 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-585
>     https://issues.apache.org/jira/browse/ATLAS-585
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added local atlas client that calls the resources directly. So, it bypasses the filters
> 
> 
> Diffs
> -----
> 
>   .gitignore ff7c32e 
>   addons/falcon-bridge/pom.xml 9b07c9f 
>   addons/hive-bridge/pom.xml e125f18 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java b0d4c5c 
>   addons/sqoop-bridge/pom.xml 4b5dbb1 
>   addons/storm-bridge/pom.xml d8d98f5 
>   client/src/main/java/org/apache/atlas/AtlasAdminClient.java 473f72a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java be34802 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 6f68a71 
>   client/src/main/java/org/apache/atlas/security/SecureClientUtils.java d3b474a 
>   client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5 
>   distro/src/conf/atlas-log4j.xml 1ac4082 
>   notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e 
>   notification/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java 177de6d 
>   pom.xml c14e0b3 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java d83c08c 
>   webapp/pom.xml 393863c 
>   webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/LocalServletRequest.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124 
>   webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 01b1cd3 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 9d60e1a 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 1eca174 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 6068007 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 480a232 
>   webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterIT.java 9e1e08f 
>   webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterIT.java ca53096 
>   webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java d497230 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 270a20d 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLTest.java 521c037 
> 
> Diff: https://reviews.apache.org/r/46650/diff/
> 
> 
> Testing
> -------
> 
> UTs and end to end test
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


--===============7296954189700038003==--