Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96C4B2009F3 for ; Thu, 5 May 2016 23:56:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 95A6F160A05; Thu, 5 May 2016 21:56:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BFFD0160A04 for ; Thu, 5 May 2016 23:56:13 +0200 (CEST) Received: (qmail 69450 invoked by uid 500); 5 May 2016 21:56:13 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 69317 invoked by uid 99); 5 May 2016 21:56:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2016 21:56:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5245F1A11EF for ; Thu, 5 May 2016 21:56:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.819 X-Spam-Level: X-Spam-Status: No, score=-0.819 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OhDiweJNqmK1 for ; Thu, 5 May 2016 21:56:09 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 659705F24A for ; Thu, 5 May 2016 21:56:08 +0000 (UTC) Received: (qmail 69311 invoked by uid 99); 5 May 2016 21:56:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2016 21:56:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 095D22B5A3F; Thu, 5 May 2016 21:56:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8196305806228480907==" MIME-Version: 1.0 Subject: Re: Review Request 46731: ATLAS-716 Entity update/delete notifications From: Suma Shivaprasad To: atlas , Shwetha GS Date: Thu, 05 May 2016 21:56:07 -0000 Message-ID: <20160505215607.1838.62089@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46731/ X-Sender: Suma Shivaprasad References: <20160427130517.26230.13889@reviews.apache.org> In-Reply-To: <20160427130517.26230.13889@reviews.apache.org> X-ReviewBoard-Diff-For: client/src/main/java/org/apache/atlas/notification/EntityNotification.java X-ReviewBoard-Diff-For: client/src/main/java/org/apache/atlas/notification/HookNotification.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java X-ReviewBoard-Diff-For: client/src/main/java/org/apache/atlas/SerDe.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java X-ReviewBoard-Diff-For: client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java X-ReviewBoard-Diff-For: client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java X-ReviewBoard-Diff-For: client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas archived-at: Thu, 05 May 2016 21:56:14 -0000 --===============8196305806228480907== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review131952 ----------------------------------------------------------- client/src/main/java/org/apache/atlas/AtlasClient.java (line 577) would be better to keep the result consistent for all CRUD operations and standardize as EntityResult - Suma Shivaprasad On April 27, 2016, 1:05 p.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46731/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 1:05 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-716 > https://issues.apache.org/jira/browse/ATLAS-716 > > > Repository: atlas > > > Description > ------- > > 1. Update/delete entity APIs return list of entities created, updated and deleted > 2. Listeners are called for all the affected entities > > > Diffs > ----- > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 104c0c5 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 813177f > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee > client/src/main/java/org/apache/atlas/AtlasClient.java be34802 > client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708 > client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION > client/src/main/java/org/apache/atlas/notification/EntityNotification.java PRE-CREATION > client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java PRE-CREATION > client/src/main/java/org/apache/atlas/notification/HookNotification.java PRE-CREATION > client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5 > client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java PRE-CREATION > client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java PRE-CREATION > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988 > notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99 > notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 1f2df3e > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java 82a1100 > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e > notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java 300cbb5 > notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java 80c96fa > notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java PRE-CREATION > notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f > notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea > pom.xml 729b178 > repository/pom.xml 533e48b > repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 540c308 > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 5b4bdbf > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 8f11322 > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 369a5d5 > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java de29e86 > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java a3dc7e5 > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940 > repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java be407a5 > repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java 84d7bab > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java ae215f9 > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 1f906ed > server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 31f157e > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java b14aa80 > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java d6199ab > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java 03a0d3f > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 54d8d92 > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 720ce79 > webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java 2d510a0 > > Diff: https://reviews.apache.org/r/46731/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > Shwetha GS > > --===============8196305806228480907==--