Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EC3B4200A01 for ; Tue, 3 May 2016 15:22:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EB5841609F4; Tue, 3 May 2016 15:22:11 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2224B1609F3 for ; Tue, 3 May 2016 15:22:10 +0200 (CEST) Received: (qmail 84661 invoked by uid 500); 3 May 2016 13:22:10 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 84645 invoked by uid 99); 3 May 2016 13:22:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 May 2016 13:22:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AA72F1A10A3 for ; Tue, 3 May 2016 13:22:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.02 X-Spam-Level: X-Spam-Status: No, score=-2.02 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id gEGDOZgo19NP for ; Tue, 3 May 2016 13:22:08 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 975255F488 for ; Tue, 3 May 2016 13:22:07 +0000 (UTC) Received: (qmail 84623 invoked by uid 99); 3 May 2016 13:22:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 May 2016 13:22:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 554182B4C9A; Tue, 3 May 2016 13:22:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8114728879133334603==" MIME-Version: 1.0 Subject: Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload From: Tom Beerbower To: Tom Beerbower , Hemanth Yamijala , atlas , Shwetha GS Date: Tue, 03 May 2016 13:22:01 -0000 Message-ID: <20160503132201.19046.57030@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Tom Beerbower X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45720/ X-Sender: Tom Beerbower References: <20160503105154.19045.67388@reviews.apache.org> In-Reply-To: <20160503105154.19045.67388@reviews.apache.org> X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/MessageVersionTest.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/IncompatibleVersionException.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/entity/EntityMessageDeserializer.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java X-ReviewBoard-Diff-For: notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/MessageDeserializer.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/MessageVersion.java X-ReviewBoard-Diff-For: notification/src/main/java/org/apache/atlas/notification/hook/HookMessageDeserializer.java Reply-To: Tom Beerbower X-ReviewRequest-Repository: atlas archived-at: Tue, 03 May 2016 13:22:12 -0000 --===============8114728879133334603== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ ----------------------------------------------------------- (Updated May 3, 2016, 1:21 p.m.) Review request for atlas. Changes ------- make checkstyle happy Bugs: ATLAS-631 https://issues.apache.org/jira/browse/ATLAS-631 Repository: atlas Description ------- 1. Introduce Versioning to Atlas Notification Payload (both ways) 2. For any messages that are not able to be processed, log the message do a separate log file for unprocessed messages. Diffs (updated) ----- notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 029a072 notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 889af11 notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988 notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99 notification/src/main/java/org/apache/atlas/notification/IncompatibleVersionException.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/MessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/MessageVersion.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/entity/EntityMessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/hook/HookMessageDeserializer.java PRE-CREATION notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java db34815 notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/MessageVersionTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea Diff: https://reviews.apache.org/r/45720/diff/ Testing ------- New unit tests added. mvn clean test. Thanks, Tom Beerbower --===============8114728879133334603==--