atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it
Date Tue, 24 May 2016 19:18:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134617
-----------------------------------------------------------




addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java (line 742)
<https://reviews.apache.org/r/47638/#comment199461>

    can you pls add a test with column position changed as well


- Suma Shivaprasad


On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47638/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 6:52 a.m.)
> 
> 
> Review request for atlas and Shwetha GS.
> 
> 
> Bugs: ATLAS-752
>     https://issues.apache.org/jira/browse/ATLAS-752
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-752 When a column is renamed, the traits associted with it are lost. The traits
should be retained with the new column
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 418e755 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 70100f1

> 
> Diff: https://reviews.apache.org/r/47638/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Revised Patch
>   https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message