atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 47571: JAAS configuration needed for Kafka interaction via Atlas config file
Date Thu, 19 May 2016 03:22:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47571/#review133863
-----------------------------------------------------------




common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java (line 146)
<https://reviews.apache.org/r/47571/#comment198510>

    Please ensure that the opened input stream is closed.



common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java (line 153)
<https://reviews.apache.org/r/47571/#comment198515>

    This would return only the configurations that start with "option". Perhaps you meant
to use JAAS_CONFIG_PREFIX_PARAM ("atlas.jass.") instead of JAAS_CONFIG_LOGIN_OPTIONS_PREFIX
("option"). Please review.
    
    Also, initilize() method processes only properties that start with JAAS_CONFIG_PREFIX_PARAM
(line #205). However, subset() call here would strip the given prefix. Given that necessary
filtering is done in initialize() method, is it necessary to get a subset here?
    
    Ref: http://commons.apache.org/proper/commons-configuration/javadocs/v1.10/apidocs/index.html



common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java (line 168)
<https://reviews.apache.org/r/47571/#comment198512>

    Looks like properties loading is done in the constructor - line #167. Please review and
move the logs accordingly.
    
    Better yet, consider moving these logs to InMemoryJAASConfiguration.initialize() method.



common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java (line 180)
<https://reviews.apache.org/r/47571/#comment198513>

    Please add entry/exit debug logs. These will be handy while troubleshooting.


- Madhan Neethiraj


On May 19, 2016, 2:51 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47571/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 2:51 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Ramesh Mani, Shwetha GS, Suma Shivaprasad,
and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-809
>     https://issues.apache.org/jira/browse/ATLAS-809
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> In-Memory JAAS configurator obviates need for passing -Djava.security.auth.login.config
command line argument to JVMs when starting various components that may interact with Kafka.
> 
> 
> Diffs
> -----
> 
>   common/pom.xml 614b3f6 
>   common/src/main/java/org/apache/atlas/ApplicationProperties.java 6a4dca3 
>   common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTest.java PRE-CREATION

>   common/src/test/resources/atlas-jaas.properties PRE-CREATION 
>   distro/src/conf/atlas-application.properties d4722fb 
>   typesystem/src/main/resources/atlas-application.properties a8e77bb 
> 
> Diff: https://reviews.apache.org/r/47571/diff/
> 
> 
> Testing
> -------
> 
> Passed unit tests.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message