atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 46330: Refactor local type-system cache with cache provider interface
Date Wed, 18 May 2016 16:29:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46330/#review133761
-----------------------------------------------------------




typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java
(line 162)
<https://reviews.apache.org/r/46330/#comment198358>

    Sorry I missed this earlier. Shouldn't the write to type store happen here?


- Shwetha GS


On May 17, 2016, 2:55 p.m., venkata madugundu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46330/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 2:55 p.m.)
> 
> 
> Review request for atlas, David Kantor and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-683
>     https://issues.apache.org/jira/browse/ATLAS-683
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The local type-cache has been carved out as an interface ITypeCacheProvider and the TypeSystem
code has been refactored to use an instance of ITypeCacheProvider injected through Guice.
An instance of ITypeCacheProvider is created by looking up the implementation class specified
in atlas-application.properties (property - atlas.typesystem.cache.provider). The default
implementation is a local cache implemented by DefaultTypeCacheProvider.
> 
> 
> Diffs
> -----
> 
>   .gitignore f5899e2069d29d71378cabe51900c120db19eef9 
>   common/src/main/java/org/apache/atlas/AtlasRuntimeException.java PRE-CREATION 
>   distro/src/conf/atlas-application.properties 68a002115bdda99fba4dcace5ab97399c59289d9

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 7763ebc39593d2ba747bd53e861f1d35657c8ea1

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java
PRE-CREATION 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/ITypeCacheProvider.java
PRE-CREATION 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProviderTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46330/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for the local cache DefaultTypeCacheProvider have been authored and all other
affected unit tests of TypeSystem interface are modified to function in the presence of a
type cache provider. Ran all tests of Atlas.
> 
> 
> Thanks,
> 
> venkata madugundu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message