atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Speidel <jspei...@hortonworks.com>
Subject Re: Review Request 47382: ATLAS-491 : Business Catalog API
Date Mon, 16 May 2016 15:03:01 GMT


> On May 16, 2016, 6:31 a.m., Hemanth Yamijala wrote:
> >

"id" is the "clean" form for the underlying "__guid" property.  
The mapping between clean and fully qualified property names is handled by the PropertyMapper
implementation.
The user only deals with the clean name which is then translated to the fully qualified name
which is used in the back end operations.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47382/#review133330
-----------------------------------------------------------


On May 14, 2016, 12:58 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47382/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:58 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-491
>     https://issues.apache.org/jira/browse/ATLAS-491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial implementation of Catalog API.
> 
> Known Issues/Limitations:
> - No update/delete support for taxonomies/terms
>   -- this will be added next week
> - Some gaps in test coverage
>   - Need more in-depth test coverage that exercise the generated gremlin pipeline
> - some refactoring should still be done espcecially in the 'query' package
> - need to add more logging
> - need to finish some javadoc
> 
> 
> Diffs
> -----
> 
>   catalog/pom.xml PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/CollectionRequest.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/DefaultDateFormatter.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/InstanceRequest.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/JsonSerializer.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyMapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/PropertyValueFormatter.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/Request.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceComparator.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/Result.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/TermPath.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/ResourceDefinition.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogException.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/exception/CatalogRuntimeException.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidPayloadException.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/InvalidQueryException.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceAlreadyExistsException.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/exception/ResourceNotFoundException.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/projection/Projection.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/projection/ProjectionResult.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/projection/Relation.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/AlwaysQueryExpression.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQueryExpression.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/PrefixQueryExpression.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/RegexQueryExpression.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/TermQueryExpression.java PRE-CREATION

>   catalog/src/main/java/org/apache/atlas/catalog/query/TermRangeQueryExpression.java
PRE-CREATION 
>   catalog/src/main/java/org/apache/atlas/catalog/query/WildcardQueryExpression.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/DefaultDateFormatterTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/DefaultPropertyMapperTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/InstanceRequestTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java PRE-CREATION

>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityResourceDefinitionTest.java
PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java
PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java
PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java
PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/AlwaysQueryExpressionTest.java
PRE-CREATION 
>   catalog/src/test/java/org/apache/atlas/catalog/query/QueryFactoryTest.java PRE-CREATION

>   pom.xml 5e2871e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cccafc2

>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5195cbe

>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 13d20d8 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java
6fb2087 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java
b97669a 
>   webapp/pom.xml de48c15 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogExceptionMapper.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/resources/CatalogRuntimeExceptionMapper.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java PRE-CREATION

>   webapp/src/main/webapp/WEB-INF/web.xml f0b606e 
> 
> Diff: https://reviews.apache.org/r/47382/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing unit tests and added new tests.
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message