atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keval bhatt <keval.bh...@freestoneinfotech.com>
Subject Re: Review Request 47293: ATLAS-736 :: UI - BUG :: displaying timestamp values for hive_db description
Date Fri, 13 May 2016 10:39:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47293/
-----------------------------------------------------------

(Updated May 13, 2016, 10:39 a.m.)


Review request for atlas, Ayub Pathan, Gautam Borad, Shwetha GS, Selvamohan Neethiraj, and
Hemanth Yamijala.


Changes
-------

Handled all your suggestions. 

Overall Patch contains :: 
1) It takes care of Null values in all Table columns (in search result Table).
2) Corrected error response as well as success message as per your suggestion. 
3) Corrected display of Top Navigation menu item of current page  (sometimes it was showing
improper top navigation menu item)
4) Improvised by adding a common function view to show the modal for Delete Tag.


Bugs: ATLAS-736
    https://issues.apache.org/jira/browse/ATLAS-736


Repository: atlas


Description
-------

Bug Description : Showing date in description if description is null same for other colums

Changed: * Validation added to handle null value and showing empty value.
         * Removed Tools column for add tag and add tag button displayed after tags.
         * Search table loading effect improvements.
         * Header Menu fix.


Diffs (updated)
-----

  dashboardv2/public/css/override.css 4c452cc 
  dashboardv2/public/index.html c2f15c9 
  dashboardv2/public/js/utils/CommonViewFunction.js PRE-CREATION 
  dashboardv2/public/js/views/asset/AssetPageLayoutView.js c86fef4 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
  dashboardv2/public/js/views/site/Header.js 500bd91 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c5e1ace 
  dashboardv2/public/js/views/tag/addTagModalView.js d663ae2 

Diff: https://reviews.apache.org/r/47293/diff/


Testing
-------

Manually tested the changes.


Thanks,

keval bhatt


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message