atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 47107: ATLAS_619 Normalize literals for hive queries
Date Thu, 12 May 2016 21:38:41 GMT


> On May 12, 2016, 9:21 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
line 192
> > <https://reviews.apache.org/r/47107/diff/2/?file=1380630#file1380630line192>
> >
> >     What about for dataset - don't you want to do the same changes for dataset as
well? or planning to do it in another jira?

this is being tracked in ATLAS-542. Will take care as part of that. It may not be needed if
we go for qualifiedName as expressions.


- Suma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47107/#review132845
-----------------------------------------------------------


On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47107/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 7:01 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-619
>     https://issues.apache.org/jira/browse/ATLAS-619
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Normlized all literals in a query and replacing them CONSTANT literals. Storing recently
run queries in  a new attribute for hive_process - recentQueries
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 8fced05

>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
2494675 
>   addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 4e2a06f

>   addons/hive-bridge/pom.xml eeb2aa4 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java ffd5d22 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
6418770 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/ASTRewriter.java PRE-CREATION

>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/HiveASTRewriter.java
PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/LiteralRewriter.java
PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteContext.java
PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java
PRE-CREATION 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java
PRE-CREATION 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java da21195

>   addons/hive-bridge/src/test/resources/hive-site.xml f1facb8 
>   addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ab7e6ee

>   addons/sqoop-bridge/src/test/java/org/apache/atlas/sqoop/hook/SqoopHookIT.java 2820169

>   addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 267e228

>   addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala
de67c39 
>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
a017536 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 9f69940

>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java 66e1365 
>   typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
73b3526 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 70dce6b 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java cdf6049 
>   webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java
bc02f90 
> 
> Diff: https://reviews.apache.org/r/47107/diff/
> 
> 
> Testing
> -------
> 
> Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message