atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 47111: ATLAS-738 Add query ability on system properties like guid, state, createdtime etc
Date Tue, 10 May 2016 11:38:31 GMT


> On May 9, 2016, 9:11 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/Constants.java, line 69
> > <https://reviews.apache.org/r/47111/diff/1/?file=1376196#file1376196line69>
> >
> >     move this as well to TypesUtil?

Want to keep it in Constants so that if another system attribute is added and needs to be
added to getAttributeInfoForSystemAttributes, they can look at it. Moving to TypesUtil, it
won't be relevant there? Makes sense?


- Shwetha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47111/#review132329
-----------------------------------------------------------


On May 9, 2016, 8:02 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47111/
> -----------------------------------------------------------
> 
> (Updated May 9, 2016, 8:02 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-738
>     https://issues.apache.org/jira/browse/ATLAS-738
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add query ability on system properties like guid, state, createdtime etc
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/Constants.java 0832c81 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
de29e86 
>   repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala 552cc32 
>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
9cc501f 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 330d1cb

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 2ea90a3

> 
> Diff: https://reviews.apache.org/r/47111/diff/
> 
> 
> Testing
> -------
> 
> UTs
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message