atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 46943: ATLAS-690: Read timed out exceptions when tables are imported into Atlas.
Date Wed, 04 May 2016 11:11:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46943/#review131652
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 397)
<https://reviews.apache.org/r/46943/#comment195683>

    Use - vertex[id=%s]



repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (lines 405 - 406)
<https://reviews.apache.org/r/46943/#comment195684>

    Use 'edge[id=%s]'


- Shwetha GS


On May 4, 2016, 10:58 a.m., Hemanth Yamijala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46943/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 10:58 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-690
>     https://issues.apache.org/jira/browse/ATLAS-690
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The patch fixes two regressions caused in Atlas code base recently.
> 
> * A regression involving missing out adding the right indexes
> * A regression that caused a quadratic load of vertices for hive objects.
> 
> The first one was fixed by correcting the indexes back. The second one was fixed by having
a per request cache. Some other indexing changes are due to what looks like a Titan issue.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 36d8034

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
d83c08c 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java c542ec7

>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
a3dc7e5 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java
PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerTest.java
87fdf87 
> 
> Diff: https://reviews.apache.org/r/46943/diff/
> 
> 
> Testing
> -------
> 
> * Ran a local run of 1000 hive tables and verified the time taken is as before the regressions
were introduced.
> * All existing UTs / ITs pass. New UT for testing index addition added.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message