atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tom Beerbower <tbeerbo...@hortonworks.com>
Subject Re: Review Request 45720: Introduce Versioning to Atlas Notification Payload
Date Tue, 03 May 2016 13:22:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45720/
-----------------------------------------------------------

(Updated May 3, 2016, 1:21 p.m.)


Review request for atlas.


Changes
-------

make checkstyle happy


Bugs: ATLAS-631
    https://issues.apache.org/jira/browse/ATLAS-631


Repository: atlas


Description
-------

1. Introduce Versioning to Atlas Notification Payload (both ways)
2. For any messages that are not able to be processed, log the message do a separate log file
for unprocessed messages.


Diffs (updated)
-----

  notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 029a072 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 889af11 
  notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988

  notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java
1cadb99 
  notification/src/main/java/org/apache/atlas/notification/IncompatibleVersionException.java
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/notification/MessageDeserializer.java PRE-CREATION

  notification/src/main/java/org/apache/atlas/notification/MessageVersion.java PRE-CREATION

  notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa

  notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java PRE-CREATION

  notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/notification/entity/EntityMessageDeserializer.java
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/notification/hook/HookMessageDeserializer.java
PRE-CREATION 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java PRE-CREATION 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java db34815 
  notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
PRE-CREATION 
  notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java PRE-CREATION

  notification/src/test/java/org/apache/atlas/notification/MessageVersionTest.java PRE-CREATION

  notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java PRE-CREATION

  notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java
PRE-CREATION 
  notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java
385c41f 
  notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java
PRE-CREATION 
  notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
57b0eea 

Diff: https://reviews.apache.org/r/45720/diff/


Testing
-------

New unit tests added.

mvn clean test.


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message