Return-Path: X-Original-To: apmail-atlas-dev-archive@minotaur.apache.org Delivered-To: apmail-atlas-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65D30193AB for ; Fri, 15 Apr 2016 17:35:40 +0000 (UTC) Received: (qmail 78934 invoked by uid 500); 15 Apr 2016 17:35:40 -0000 Delivered-To: apmail-atlas-dev-archive@atlas.apache.org Received: (qmail 78884 invoked by uid 500); 15 Apr 2016 17:35:40 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 78868 invoked by uid 99); 15 Apr 2016 17:35:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 17:35:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A28681A0262 for ; Fri, 15 Apr 2016 17:35:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.569 X-Spam-Level: X-Spam-Status: No, score=-0.569 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id clWc3YGvAAlS for ; Fri, 15 Apr 2016 17:35:38 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 26C955F239 for ; Fri, 15 Apr 2016 17:35:36 +0000 (UTC) Received: (qmail 78837 invoked by uid 99); 15 Apr 2016 17:35:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 17:35:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 99C4F1C023E; Fri, 15 Apr 2016 17:35:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3726365027727871276==" MIME-Version: 1.0 Subject: Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries From: Suma Shivaprasad To: Jeff Hagelberg , David Kantor Cc: atlas , Neeru Gupta Date: Fri, 15 Apr 2016 17:35:32 -0000 Message-ID: <20160415173532.29094.49455@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45499/ X-Sender: Suma Shivaprasad References: <20160414141123.29094.89561@reviews.apache.org> In-Reply-To: <20160414141123.29094.89561@reviews.apache.org> Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas --===============3726365027727871276== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129154 ----------------------------------------------------------- repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala (line 347) this var could be renamed from count to something else since its a bit confusing..since its the end offset if I am correct? - Suma Shivaprasad On April 14, 2016, 2:11 p.m., Neeru Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45499/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 2:11 p.m.) > > > Review request for atlas, David Kantor and Jeff Hagelberg. > > > Bugs: ATLAS-435 and ATLAS-436 > https://issues.apache.org/jira/browse/ATLAS-435 > https://issues.apache.org/jira/browse/ATLAS-436 > > > Repository: atlas > > > Description > ------- > > ATLAS-435, 436 order by and limit clause in DSL > > > Diffs > ----- > > repository/src/main/scala/org/apache/atlas/query/Expressions.scala a5dfa9f409c0d810be7449413f5c2d53d5103dce > repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala edb190db599d43eb98eca13c7907c73e7d77ae34 > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala f1590a884eda007182dad7541a2bc8eb97d68fbc > repository/src/main/scala/org/apache/atlas/query/QueryParser.scala b6bbbd31a91dd2d0ff3e9082abafff3539765a01 > repository/src/main/scala/org/apache/atlas/query/Resolver.scala c7e1e81a555d57be1d7f63cb84a1c8f550ac37ab > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf0e6071a961aa5d030f0340358e79e446b > > Diff: https://reviews.apache.org/r/45499/diff/ > > > Testing > ------- > > Manual and unit testing done for various DSL queries. Have added test cases in GraphBackedDiscoveryServiceTest for orderby and limit clause for various queries. > > Order by clause is limited to specifying one criterian only. Comparison is case insensitive. > > > Thanks, > > Neeru Gupta > > --===============3726365027727871276==--