Return-Path: X-Original-To: apmail-atlas-dev-archive@minotaur.apache.org Delivered-To: apmail-atlas-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3A2219AD5 for ; Tue, 12 Apr 2016 18:57:11 +0000 (UTC) Received: (qmail 61601 invoked by uid 500); 12 Apr 2016 18:57:11 -0000 Delivered-To: apmail-atlas-dev-archive@atlas.apache.org Received: (qmail 61550 invoked by uid 500); 12 Apr 2016 18:57:11 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 61539 invoked by uid 99); 12 Apr 2016 18:57:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 18:57:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C42DF1A0731 for ; Tue, 12 Apr 2016 18:57:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.819 X-Spam-Level: X-Spam-Status: No, score=-0.819 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id xEnUze2PFKEK for ; Tue, 12 Apr 2016 18:57:08 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1B7235F5A1 for ; Tue, 12 Apr 2016 18:57:06 +0000 (UTC) Received: (qmail 61527 invoked by uid 99); 12 Apr 2016 18:57:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 18:57:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5BFB2AFB82; Tue, 12 Apr 2016 18:57:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1650628304774622304==" MIME-Version: 1.0 Subject: Re: Review Request 46011: ATLAS-622 Introduce soft delete From: Suma Shivaprasad To: atlas , Shwetha GS Date: Tue, 12 Apr 2016 18:57:02 -0000 Message-ID: <20160412185702.29094.19707@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46011/ X-Sender: Suma Shivaprasad References: <20160412152717.21369.84589@reviews.apache.org> In-Reply-To: <20160412152717.21369.84589@reviews.apache.org> X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteEntitiesTest.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedReposiotrySoftDeleteTest.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas --===============1650628304774622304== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46011/#review128505 ----------------------------------------------------------- repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java (line 244) Please enable this check. Raising this to track so that we dont miss - Suma Shivaprasad On April 12, 2016, 3:27 p.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46011/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 3:27 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-622 > https://issues.apache.org/jira/browse/ATLAS-622 > > > Repository: atlas > > > Description > ------- > > Added soft delete which is enabled by default. Hard delete can be configured using guice. Had to refactor entity deletes. > > Pending: > 1. GraphBackedMetadataRepositoryDeleteEntitiesTest.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes is disabled, need to debug > 2. Have to write more tests for soft deletes > 3. hive hook tests - have fixed some tests, 13/40 are still failing > > > Diffs > ----- > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 6b348e2 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java b947a8c > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 2f0c71f > client/src/main/java/org/apache/atlas/AtlasClient.java 938a0a3 > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java ce1bdfb > repository/src/main/java/org/apache/atlas/repository/graph/AtlasEdgeLabel.java da2ad9a > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java PRE-CREATION > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java b94ff5a > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java e7e8fb9 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 895f9df > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1d682bb > repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java PRE-CREATION > repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java PRE-CREATION > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 7011fdf > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 71e9028 > repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java d07f89d > repository/src/test/java/org/apache/atlas/TestUtils.java a3cf929 > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java ea93cbf > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteEntitiesTest.java 975d530 > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java PRE-CREATION > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java b5440c2 > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedReposiotrySoftDeleteTest.java PRE-CREATION > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java PRE-CREATION > repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java 3f71eb3 > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 8ca3132 > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 156eb3d > repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 0289b1a > repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 79ebfae > repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala cd1c424 > server-api/src/main/java/org/apache/atlas/RequestContext.java 943e4b8 > typesystem/src/main/java/org/apache/atlas/typesystem/IInstance.java ffe40a7 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 7857483 > typesystem/src/main/java/org/apache/atlas/typesystem/Struct.java 70deab2 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/DownCastStructInstance.java d3b9a33 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java d742bb7 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java 0fa4666 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 16c3a24 > typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 55ec91f > typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java eb1a15a > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java b2e9f91 > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 6a939d3 > > Diff: https://reviews.apache.org/r/46011/diff/ > > > Testing > ------- > > UTs, ITs > > > Thanks, > > Shwetha GS > > --===============1650628304774622304==--