Return-Path: X-Original-To: apmail-atlas-dev-archive@minotaur.apache.org Delivered-To: apmail-atlas-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5CB219AF5 for ; Tue, 12 Apr 2016 13:41:08 +0000 (UTC) Received: (qmail 64065 invoked by uid 500); 12 Apr 2016 13:41:08 -0000 Delivered-To: apmail-atlas-dev-archive@atlas.apache.org Received: (qmail 64013 invoked by uid 500); 12 Apr 2016 13:41:08 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 64002 invoked by uid 99); 12 Apr 2016 13:41:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 13:41:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C24A9C0224 for ; Tue, 12 Apr 2016 13:41:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.02 X-Spam-Level: X-Spam-Status: No, score=-2.02 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 9Kj9spClpJwn for ; Tue, 12 Apr 2016 13:41:06 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 6D3725FB2A for ; Tue, 12 Apr 2016 13:41:06 +0000 (UTC) Received: (qmail 63995 invoked by uid 99); 12 Apr 2016 13:41:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 13:41:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 469ED2AFA1C; Tue, 12 Apr 2016 13:41:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5814497905782983172==" MIME-Version: 1.0 Subject: Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output() From: David Kantor To: David Kantor , atlas Date: Tue, 12 Apr 2016 13:41:02 -0000 Message-ID: <20160412134102.29094.74021@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David Kantor X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45948/ X-Sender: David Kantor References: <20160408212908.26225.71658@reviews.apache.org> In-Reply-To: <20160408212908.26225.71658@reviews.apache.org> X-ReviewBoard-Diff-For: typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java Reply-To: David Kantor X-ReviewRequest-Repository: atlas --===============5814497905782983172== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/ ----------------------------------------------------------- (Updated April 12, 2016, 1:41 p.m.) Review request for atlas. Bugs: ATLAS-645 https://issues.apache.org/jira/browse/ATLAS-645 Repository: atlas Description ------- ATLAS-645: In FieldMapping.output(), avoid infinite recursion when IReferenceableInstance and IStruct instances reference each other. Diffs ----- typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java 36149bafff80b68ce176e82dcacac87035459362 typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45948/diff/ Testing ------- Ran all unit and integration tests with no regressions. Added test cases Thanks, David Kantor --===============5814497905782983172==--