atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Kantor <dkan...@us.ibm.com>
Subject Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()
Date Fri, 29 Apr 2016 19:24:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/
-----------------------------------------------------------

(Updated April 29, 2016, 7:24 p.m.)


Review request for atlas.


Changes
-------

Addressed Shwetha's comments.  Reimplemented to use thread local storage for the inProcess
set rather than passing as an method argument.


Bugs: ATLAS-645
    https://issues.apache.org/jira/browse/ATLAS-645


Repository: atlas


Description
-------

ATLAS-645: In FieldMapping.output(), avoid infinite recursion when IReferenceableInstance
and IStruct instances reference each other.


Diffs (updated)
-----

  typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java af62442bfe5daa221079207acf361e1316cab3ad

  typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java 36149bafff80b68ce176e82dcacac87035459362

  typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 89fcea6828c9e23c28a60952c3e4ca27c0667494

  typesystem/src/main/java/org/apache/atlas/typesystem/types/OutputStatus.java PRE-CREATION

  typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 54e344f5d6322a00ac7825ee8964f43a1552dcbe

  typesystem/src/test/java/org/apache/atlas/typesystem/types/OutputStatusTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/45948/diff/


Testing
-------

Ran all unit and integration tests with no regressions.  Added test cases


Thanks,

David Kantor


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message