atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Bergenholtz <ebergenho...@hortonworks.com>
Subject Re: Review Request 46197: ATLAS-658 : Improve Lineage with Backbone porting
Date Fri, 22 Apr 2016 00:07:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46197/#review129990
-----------------------------------------------------------


Ship it!




Lineage browser looks very good.

- Erik Bergenholtz


On April 14, 2016, 1:24 p.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46197/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 1:24 p.m.)
> 
> 
> Review request for atlas, Erik Bergenholtz, Gautam Borad, Mehul Parikh, Nixon Rodrigues,
and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-658
>     https://issues.apache.org/jira/browse/ATLAS-658
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Improved display of vertices and edges in lineage graph that gets generated.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/override.css 4c452cc 
>   dashboardv2/public/css/style.css d1d23cc 
>   dashboardv2/public/js/collection/BaseCollection.js 2018019 
>   dashboardv2/public/js/collection/VCommonList.js d9e1f52 
>   dashboardv2/public/js/collection/VSchemaList.js 6a5c9d6 
>   dashboardv2/public/js/collection/VTagList.js 9fa48bf 
>   dashboardv2/public/js/modules/Helpers.js 4deb19b 
>   dashboardv2/public/js/templates/common/TableLayout_tmpl.html 4264035 
>   dashboardv2/public/js/templates/common/modal.html 0f64f5a 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 3a8eb44

>   dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 0c32a48 
>   dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html cbc0e8a 
>   dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html acae4e1 
>   dashboardv2/public/js/utils/Overrides.js 3b598e3 
>   dashboardv2/public/js/utils/Utils.js 7b2db79 
>   dashboardv2/public/js/views/asset/AssetPageLayoutView.js c86fef4 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 87adec0 
>   dashboardv2/public/js/views/graph/LineageLayoutView.js 973d091 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js 35487a5 
>   dashboardv2/public/js/views/site/Header.js 500bd91 
>   dashboardv2/public/js/views/tag/TagLayoutView.js 42791b9 
>   dashboardv2/public/js/views/tag/addTagModalView.js d663ae2 
>   dashboardv2/public/js/views/tag/createTagsLayoutView.js 5d93eee 
> 
> Diff: https://reviews.apache.org/r/46197/diff/
> 
> 
> Testing
> -------
> 
> 1) mvn tests
> 2) Loaded the new UI in local sandbox and verified Lineage graph generation with proper
vcertices and edges shown based on input and output of API calls.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message