atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 46409: ATLAS-583 Rename table should retain column, partition columns tags
Date Wed, 20 Apr 2016 21:57:23 GMT


> On April 20, 2016, 4:36 a.m., Hemanth Yamijala wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, line
421
> > <https://reviews.apache.org/r/46409/diff/1/?file=1351748#file1351748line421>
> >
> >     For my understanding, can you please explain why this step is necessary. It
looks like our change sequence is:
> >     
> >     * Update DB / Table entity - retaining the old name of table.
> >     * Update Storage Descriptor / Columns.
> >     * Partial update table with new name.
> >     
> >     I am trying to understand why Step 1 is required. Is it to take care of situations
where the old table did not exist before in Atlas?
> 
> Suma Shivaprasad wrote:
>     Yes its required to create old table state when it doesnt exist

Keeping it open in case you have any further comments/questions


- Suma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46409/#review129681
-----------------------------------------------------------


On April 20, 2016, 9:54 p.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46409/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 9:54 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-583
>     https://issues.apache.org/jira/browse/ATLAS-583
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Fixed it by first renaming the columns, sd, partition keys and then renaming the table
so that the columns, sd, etc are not deleted/recreated again becaused they are deduped based
on their QualifiedName which has tableName as part of it.
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
a28b4ac 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 749294f 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
f099e39 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 4c7ac70

>   client/src/main/java/org/apache/atlas/AtlasClient.java 22a1726 
> 
> Diff: https://reviews.apache.org/r/46409/diff/
> 
> 
> Testing
> -------
> 
> Added tests in HiveHookIT
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message