atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Kantor <dkan...@us.ibm.com>
Subject Re: Review Request 45948: Atlas-645: avoid infinite recursion in FieldMapping.output()
Date Fri, 15 Apr 2016 18:36:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/
-----------------------------------------------------------

(Updated April 15, 2016, 6:36 p.m.)


Review request for atlas.


Changes
-------

Addressed Hemanth and Shwetha's comment - removed mutable state from FieldMapping, added IStruct
methods to track output status that are implemented in new base class AbstractStruct.


Bugs: ATLAS-645
    https://issues.apache.org/jira/browse/ATLAS-645


Repository: atlas


Description
-------

ATLAS-645: In FieldMapping.output(), avoid infinite recursion when IReferenceableInstance
and IStruct instances reference each other.


Diffs (updated)
-----

  typesystem/src/main/java/org/apache/atlas/typesystem/AbstractStruct.java PRE-CREATION 
  typesystem/src/main/java/org/apache/atlas/typesystem/IStruct.java e0f85761a0f436cd4b4cd355d6c8ab65dca7fcc9

  typesystem/src/main/java/org/apache/atlas/typesystem/Struct.java 70deab29df36e7e18f517c4880d7088f8bec06a5

  typesystem/src/main/java/org/apache/atlas/typesystem/persistence/DownCastStructInstance.java
d3b9a3376ebce92ff8b50708fa841ab5868b366a 
  typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java d742bb73e89772afcf8e0bd25f4fda9b7c94758b

  typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java 16c3a24e51f0389946e0e6094a6a3e4e1b9dff0f

  typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java 36149bafff80b68ce176e82dcacac87035459362

  typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/45948/diff/


Testing
-------

Ran all unit and integration tests with no regressions.  Added test cases


Thanks,

David Kantor


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message