atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hemanth Yamijala <yhema...@gmail.com>
Subject Re: Review Request 45558: ATLAS-540 API to retrieve entity version events
Date Mon, 11 Apr 2016 08:07:48 GMT


> On April 4, 2016, 1:33 p.m., Hemanth Yamijala wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java,
line 176
> > <https://reviews.apache.org/r/45558/diff/2/?file=1324007#file1324007line176>
> >
> >     Shouldn't we break here? Once an entityId is crossed, we would not get any results
that would apply for this entityId anymore, right?
> 
> Shwetha GS wrote:
>     With reverse scan, this should be continue
> 
> Hemanth Yamijala wrote:
>     Why? Given our key is entityId:timestamp, the scan would start working backwards
on decreasing order of timestamps. Once it has reached the earliest timestamp of an entity,
it would go to the previous entityId's latest timestamp and continue there. When would it
get back a result with the entityId of interest?
> 
> Shwetha GS wrote:
>     When startKey is null, we set start row to next entity id. If there is a row with
this start key, that will be the first row and we should skip

As long as we are controlling the data in the table, this cannot happen, because any value
with a entityId:timestamp is bound to be greater than entityId alone and in a reverse scan,
it will never be returned.


- Hemanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45558/#review126818
-----------------------------------------------------------


On April 10, 2016, 7:16 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45558/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 7:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-540
>     https://issues.apache.org/jira/browse/ATLAS-540
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added REST API to get audit events. 
> 
> Pending: User info is no coming correctly. Each REST API call makes two calls - OPTIONS
call and then actual call. OPTIONS call contains the actual user in httprequest, but the actual
call contains the user in the queryparam doAs. Will debug this as part of ATLAS-585
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/pom.xml 03cb11e 
>   addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 4249a8f

>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
eb5f1e6 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 4102263 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 8ef8479

>   addons/sqoop-bridge/src/test/java/org/apache/atlas/sqoop/hook/SqoopHookIT.java 0e4658a

>   client/src/main/java/org/apache/atlas/AtlasClient.java 938a0a3 
>   client/src/main/java/org/apache/atlas/EntityAuditEvent.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/utils/ParamChecker.java 91adfaf 
>   distro/pom.xml 0de8ccf 
>   distro/src/conf/atlas-application.properties c80d2f0 
>   notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 7e09a19 
>   notification/src/main/java/org/apache/atlas/notification/NotificationModule.java e8ae177

>   pom.xml 226529d 
>   repository/pom.xml eca087a 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java ce1bdfb 
>   repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java
0c5c551 
>   repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
d41c4da 
>   repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
c4329a5 
>   repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
df75290 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 0a04c5f

>   repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
9c193f7 
>   repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 156eb3d

>   server-api/pom.xml d3e84c4 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java a2c347d 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 6bfd780

>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java f39a80e 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 8b0d0e9 
>   webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorModule.java
065666d 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 6a939d3

> 
> Diff: https://reviews.apache.org/r/45558/diff/
> 
> 
> Testing
> -------
> 
> UTs, ITs and end to end test
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message