atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nixon Rodrigues <nixon.rodrig...@freestoneinfotech.com>
Subject Re: Review Request 45029: ATLAS-494 : Authentication
Date Sat, 09 Apr 2016 19:32:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45029/
-----------------------------------------------------------

(Updated April 9, 2016, 7:32 p.m.)


Review request for atlas, Erik Bergenholtz, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.


Changes
-------

Changes includes fix for reviewboard comments for ATLAS-494.


Bugs: ATLAS-494
    https://issues.apache.org/jira/browse/ATLAS-494


Repository: atlas


Description
-------

**Problem Statement**

Atlas needs an authentication mechanism besides kerberos.
*Requirements*
Provide ability to authenticate against local file
Provide Authentication that supports LDAP
For consistency, configuration should use exactly the same configuration (properties) as Ranger
& Knox


Diffs (updated)
-----

  dashboard/public/css/login.css PRE-CREATION 
  dashboard/public/modules/home/views/header.html 896cfb4 
  distro/src/conf/atlas-application.properties c80d2f0 
  distro/src/conf/users-credentials.properties PRE-CREATION 
  pom.xml 226529d 
  webapp/pom.xml 85c9471 
  webapp/src/main/java/org/apache/atlas/util/PropertiesUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/util/XMLPropertiesUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationEntryPoint.java PRE-CREATION

  webapp/src/main/java/org/apache/atlas/web/model/User.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java PRE-CREATION

  webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationException.java PRE-CREATION

  webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java PRE-CREATION

  webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/UserService.java PRE-CREATION 
  webapp/src/main/resources/atlas-admin-site.xml PRE-CREATION 
  webapp/src/main/resources/spring-security.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 855a068 
  webapp/src/main/webapp/login.jsp PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java PRE-CREATION

  webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/45029/diff/


Testing
-------

Done.

Some existing test case were failing for master.

Failed tests: 
  HiveLineageJerseyResourceIT.setUp:52->setupInstances:169->table:234->BaseResourceIT.createInstance:129
ยป AtlasService

Tests run: 72, Failures: 1, Errors: 0, Skipped: 5


Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 28.161 sec <<< FAILURE!
- in org.apache.atlas.repository.graph.GraphBackedMetadataRepositoryDeleteEntitiesTest
testDisconnectUnidirectionalArrayReferenceFromClassType(org.apache.atlas.repository.graph.GraphBackedMetadataRepositoryDeleteEntitiesTest)
 Time elapsed: 0.756 sec  <<< FAILURE!
org.apache.atlas.repository.RepositoryException: org.apache.atlas.typesystem.types.ValueConversionException$NullConversionException:
For field 'columns'
	at org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:157)
	at org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:45)
	at org.apache.atlas.typesystem.types.DataTypes$ArrayType.convert(DataTypes.java:490)
	at org.apache.atlas.typesystem.types.DataTypes$ArrayType.convert(DataTypes.java:459)
	at org.apache.atlas.typesystem.persistence.StructInstance.set(StructInstance.java:122)
	at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapVertexToArrayInstance(GraphToTypedInstanceMapper.java:196)
	at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapVertexToAttribute(GraphToTypedInstanceMapper.java:122)
	at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapVertexToInstance(GraphToTypedInstanceMapper.java:95)
	at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapGraphToTypedInstance(GraphToTypedInstanceMapper.java:74)
	at org.apache.atlas.repository.graph.GraphBackedMetadataRepository.getEntityDefinition(GraphBackedMetadataRepository.java:144)
	at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:42)
	at org.apache.atlas.repository.graph.GraphBackedMetadataRepositoryDeleteEntitiesTest.testDisconnectUnidirectionalArrayReferenceFromClassType(GraphBackedMetadataRepositoryDeleteEntitiesTest.java:324)


Thanks,

Nixon Rodrigues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message