atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hemanth Yamijala <hyamij...@hortonworks.com>
Subject Re: Review Request 45029: ATLAS-494 : Authentication
Date Wed, 06 Apr 2016 04:56:49 GMT
+1




On 4/6/16, 10:24 AM, "Shwetha Shivalingamurthy" <sshivalingamurthy@hortonworks.com>
wrote:

>Lets keep it as admin=admin, consistent with ambari default?
>
>Regards,
>Shwetha
>
>
>From: Hemanth Yamijala <noreply@reviews.apache.org<mailto:noreply@reviews.apache.org>>
on behalf of Hemanth Yamijala <yhemanth@gmail.com<mailto:yhemanth@gmail.com>>
>Reply-To: Hemanth Yamijala <yhemanth@gmail.com<mailto:yhemanth@gmail.com>>
>Date: Wednesday, 6 April 2016 at 10:11 AM
>To: Erik Bergenholtz <ebergenholtz@hortonworks.com<mailto:ebergenholtz@hortonworks.com>>,
Hemanth Yamijala <yhemanth@gmail.com<mailto:yhemanth@gmail.com>>, Shwetha Shivalingamurthy
<sshivalingamurthy@hortonworks.com<mailto:sshivalingamurthy@hortonworks.com>>
>Cc: atlas <dev@atlas.incubator.apache.org<mailto:dev@atlas.incubator.apache.org>>,
Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com<mailto:nixon.rodrigues@freestoneinfotech.com>>
>Subject: Re: Review Request 45029: ATLAS-494 : Authentication
>
>This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45029/
>
>distro/src/conf/users-credentials.properties<https://reviews.apache.org/r/45029/diff/2/?file=1324472#file1324472line3>(Diff
revision 2)
>
>        3
>
>username=password
>
>
>Lets just set this to 2 users: admin=admin123, and user=user123 (for 2 different roles).
>
>
>- Hemanth Yamijala
>
>
>On April 5th, 2016, 6:25 a.m. UTC, Nixon Rodrigues wrote:
>
>Review request for atlas, Erik Bergenholtz, Shwetha GS, Suma Shivaprasad, and Hemanth
Yamijala.
>By Nixon Rodrigues.
>
>Updated April 5, 2016, 6:25 a.m.
>
>Bugs: ATLAS-494<https://issues.apache.org/jira/browse/ATLAS-494>
>Repository: atlas
>Description
>
>Problem Statement
>
>Atlas needs an authentication mechanism besides kerberos.
>Requirements
>Provide ability to authenticate against local file
>Provide Authentication that supports LDAP
>For consistency, configuration should use exactly the same configuration (properties)
as Ranger & Knox
>
>
>Testing
>
>Done.
>
>Some existing test case were failing for master.
>
>Failed tests:
>  HiveLineageJerseyResourceIT.setUp:52->setupInstances:169->table:234->BaseResourceIT.createInstance:129
ยป AtlasService
>
>Tests run: 72, Failures: 1, Errors: 0, Skipped: 5
>
>Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 28.161 sec <<<
FAILURE! - in org.apache.atlas.repository.graph.GraphBackedMetadataRepositoryDeleteEntitiesTest
>testDisconnectUnidirectionalArrayReferenceFromClassType(org.apache.atlas.repository.graph.GraphBackedMetadataRepositoryDeleteEntitiesTest)
 Time elapsed: 0.756 sec  <<< FAILURE!
>org.apache.atlas.repository.RepositoryException: org.apache.atlas.typesystem.types.ValueConversionException$NullConversionException:
For field 'columns'
>    at org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:157)
>    at org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:45)
>    at org.apache.atlas.typesystem.types.DataTypes$ArrayType.convert(DataTypes.java:490)
>    at org.apache.atlas.typesystem.types.DataTypes$ArrayType.convert(DataTypes.java:459)
>    at org.apache.atlas.typesystem.persistence.StructInstance.set(StructInstance.java:122)
>    at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapVertexToArrayInstance(GraphToTypedInstanceMapper.java:196)
>    at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapVertexToAttribute(GraphToTypedInstanceMapper.java:122)
>    at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapVertexToInstance(GraphToTypedInstanceMapper.java:95)
>    at org.apache.atlas.repository.graph.GraphToTypedInstanceMapper.mapGraphToTypedInstance(GraphToTypedInstanceMapper.java:74)
>    at org.apache.atlas.repository.graph.GraphBackedMetadataRepository.getEntityDefinition(GraphBackedMetadataRepository.java:144)
>    at org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:42)
>    at org.apache.atlas.repository.graph.GraphBackedMetadataRepositoryDeleteEntitiesTest.testDisconnectUnidirectionalArrayReferenceFromClassType(GraphBackedMetadataRepositoryDeleteEntitiesTest.java:324)
>
>
>Diffs
>
>  *   dashboard/public/css/login.css (PRE-CREATION)
>  *   dashboard/public/modules/home/views/header.html (896cfb4)
>  *   distro/src/conf/atlas-application.properties (29df5b3)
>  *   distro/src/conf/users-credentials.properties (PRE-CREATION)
>  *   pom.xml (226529d)
>  *   webapp/pom.xml (85c9471)
>  *   webapp/src/main/java/org/apache/atlas/util/PropertiesUtil.java (PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/util/XMLPropertiesUtil.java (PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java (PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationEntryPoint.java
(PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/model/User.java (PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java
(PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
(PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationException.java
(PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java
(PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java
(PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java
(PRE-CREATION)
>  *   webapp/src/main/java/org/apache/atlas/web/service/UserService.java (PRE-CREATION)
>  *   webapp/src/main/resources/atlas-admin-site.xml (PRE-CREATION)
>  *   webapp/src/main/resources/spring-security.xml (PRE-CREATION)
>  *   webapp/src/main/webapp/WEB-INF/applicationContext.xml (PRE-CREATION)
>  *   webapp/src/main/webapp/WEB-INF/web.xml (855a068)
>  *   webapp/src/main/webapp/login.jsp (PRE-CREATION)
>  *   webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationLoginTest.java
(PRE-CREATION)
>
>View Diff<https://reviews.apache.org/r/45029/diff/>
>
Mime
View raw message