atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-523) Support alter view
Date Mon, 14 Mar 2016 05:10:33 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192743#comment-15192743
] 

Shwetha G S commented on ATLAS-523:
-----------------------------------

Minor comment. +1 otherwise. You can fix it and commit

{code}
+            //Check if properties dont exist
+            if (parameters != null) {
+                for (String propKey : expectedProps.keySet()) {
+                    Assert.assertNull(parameters.get(propKey));
+                }
+            }
{code}
Should be assertFalse(parameters.containsKey(propKey))?

> Support alter view
> ------------------
>
>                 Key: ATLAS-523
>                 URL: https://issues.apache.org/jira/browse/ATLAS-523
>             Project: Atlas
>          Issue Type: Sub-task
>    Affects Versions: 0.7-incubating
>            Reporter: Suma Shivaprasad
>            Assignee: Suma Shivaprasad
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-523.patch
>
>
> support alter view as select , drop, properties - https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/AlterView



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message