atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-500) UI: Search Default
Date Thu, 03 Mar 2016 05:30:18 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177217#comment-15177217
] 

Hemanth Yamijala commented on ATLAS-500:
----------------------------------------

Looked at the new patch. I think there are some issues still.

The most important one was the first point in my comment - i.e. the behavior of clicking on
a Tag in the right hand pane is changed. [~bergenholtz], I guess selecting a Tag on the right
hand pane should still fetch all entries tagged with that Tag, irrespective of the search
type that was previously selected in the search box. Is my thinking right? If yes, then the
current patch does not still address the issue. 

Regarding the hint text: This is modified to "DataSet, Process, Column" for DSL and the earlier
message retained for full text search. All these examples are actually valid DSL expressions
if the types are defined. I was wondering if we can give something that makes more sense from
a DSL perspective. For e.g. For DSL, can we say "Search using a DSL query: e.g. DataSet where
name='sales_fact'" and for free text something like "Search using a query string: sales_fact"?
Later maybe, we can provide a link to valid DSL query syntax (ATLAS-501).

Regarding the error message: I agree that the API can do better and give specific code values
for the UI to work better. It is easier to parse codes than free form text messages. I will
file an issue for this. 

For this issue, please note that the error happens chiefly for DSL search alone. This can
happen due to 3 cases:
* Not a valid DSL query. Correction - fix the DSL query
* A DSL query was not intended, instead it should have full text. Correction - do a full text
query.
* There was something really wrong with the server - can't really do much.

So, on receiving an error from the server for a DSL search alone, we could suggest the user
to switch to a full text query and give a link to do the same. This is similar to what Google
does to suggest users to use a corrected spelling etc. When ATLAS-501 is fixed, this message
could also include a link to DSL syntax and ask for correction. I don't know if this would
be a more involved fix.. if yes, maybe it can be done as an improvement.

All points mentioned here are really usability suggestions, except the one related to traits,
which could be a regression. So, I would request that be clarified and addressed first.



> UI: Search Default
> ------------------
>
>                 Key: ATLAS-500
>                 URL: https://issues.apache.org/jira/browse/ATLAS-500
>             Project: Atlas
>          Issue Type: Improvement
>    Affects Versions: 0.7-incubating
>            Reporter: Erik Bergenholtz
>            Assignee: Sanjay Patel
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-500-error.png, ATLAS-500-v0.patch, ATLAS-500-v1.patch
>
>
> The UI should provide a means of selecting the type of search performed. The UI should
not default to a fulltext search unless explicitly directed by the user. This can be confusing
to the user.
> If the DSL search does no result in any 'hits', it should so indicate.
> The search bar should provide a means by which the user can specify what type of search
to perform. One of:
> - DSL
> - FreeText
> (Gremlin should not be offered as an option through the UI)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message