atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hemanth Yamijala <yhema...@gmail.com>
Subject Re: Review Request 44100: Atlas-474: : Check for existing type system edge before creating to avoid duplicate edges
Date Tue, 08 Mar 2016 04:53:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44100/#review122474
-----------------------------------------------------------




repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
(line 268)
<https://reviews.apache.org/r/44100/#comment184472>

    I would prefer this to be a separate test. The first part ensures modifying a type to
add new supertypes, attributes does not cause duplicates. The second part ensures type updates
are essentially idempotent if repeated (which is what the original bug was about). In fact,
I wouldn't even mind if this is not tested (as we know that the first case covers it as well).
I will leave it to you to make a final call - don't feel strongly either way.



repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
(line 293)
<https://reviews.apache.org/r/44100/#comment184474>

    Some of these assertions seem repeated. Maybe we can do away with them. Would help test
cases be more focussed on testing fewer things.


- Hemanth Yamijala


On March 8, 2016, 1:54 a.m., David Kantor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44100/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 1:54 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-474
>     https://issues.apache.org/jira/browse/ATLAS-474
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-474: Check for existing type system edge before creating.  Previously no existence
check was done, and duplicate edges were added.  If the duplicate edge was for a super type,
the Atlas server startup would fail.
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java
a68db2f74066dfea02be4401f76836226e8d6879 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
a63c7cca316dcc303600f6c78c54e87e71a7c632 
>   addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java
989469f35d46ff4f3e0a6ceab774359eefcea6d0 
>   repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
bf10c8d8dead651332d350d5feaeed866b4e9576 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 889e2009e6b650c134286fde51192856e3b3a85a

>   repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java b386cf2692c2852902392c594cfa8acf192ce8ea

>   repository/src/test/java/org/apache/atlas/TestUtils.java ce59c43fc63d133798b7a896b38c30acad9a2bf1

>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
bb4e61fd36db0df04c5a069c1d93698b6ee75eb4 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteEntitiesTest.java
3681de7508bf33972b466f5666ff70e4d8ee31b0 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
83e4d85b6cfb81c83d4000fbb2142098052662cf 
>   repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
42183fd82ead7bd3464ec09dfe05f193e9766bd0 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java d95e80a17a89a478ff41382a5329e6abc7851ae5

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 7c8db8476be91c0f63964e2896a4678723932cac

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java
973a59154115be0d120c6cd435a8799bb6cd6668 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java baf5b4d4aa7578674e5d0e69fc2e9172c1bdd456

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java bd81d7fce7da83f50c86e2e104d9bd52de8ea90d

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 80968d85ebe6a115219e5a21e6caeffe80bfdb2e

>   typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala cd711d64ed366a2903f4d30f341b06eff21cc2b3

>   typesystem/src/main/scala/org/apache/atlas/typesystem/json/TypesSerialization.scala
5d50c452a4079ccb94f48ac79fe679deb804dcd9 
>   typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java
a13114684bdd46114d6f7ce7b2ac04db6607b27d 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/BaseTest.java 93dd099759bbb1bdb886bba7ef4a508e39270c38

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/ClassTest.java a0f58434679467399755518cb72afe00b22df028

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/EnumTest.java ea7a798357b36bdec82e567411b30e15c85d6df0

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/HierarchicalTypeTest.java
4e83492b6cdad197bcbdcca48b113a52d3c9be67 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java b7ac8f87b785d88871f5fbdc6a799956ad65cf40

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeInheritanceTest.java
a2dd759207739999cee0acf868b74bac36e0036b 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 4ee9f9c20158d831616d4b5a51bb98862e49a021

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 67641cc04275d2dd485c6862bbf997415ce89628

>   typesystem/src/test/scala/org/apache/atlas/typesystem/json/SerializationTest.scala
7b7df09131b2b516e158538e377d41f938d78117 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java dc5eaae1e5291dcb9841692e883c762db5da079c

>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java cd4e7431cbd29aba7713acb70ebd9e8024d4b4db

>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 7b3ca1f956189c6cf43a19af2bc8e73e0ae9e9b0

>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 585da72e617da21a4f0660e3fa5e824651a3c787

>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java
d255b7560cd1af3535ff8ee10f492ad886898982 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java ac1b5ca450352f3c243d37d3211018cf3df80024

> 
> Diff: https://reviews.apache.org/r/44100/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit and integration tests with no regressions.  Added test cases to GraphBackedTypeStoreTest
> 
> 
> Thanks,
> 
> David Kantor
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message