atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hemanth Yamijala (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-318) UI. Config file conatining UI: API endpoint + all api calls to be centralized -- config JS file for stand alone
Date Fri, 12 Feb 2016 19:37:18 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145149#comment-15145149
] 

Hemanth Yamijala commented on ATLAS-318:
----------------------------------------

Few comments / questions:

* In config.js, the host and port are hardcoded to some values. Typically, in the Java world,
these come from some config file or config parameters. Is this the standard way of doing this
in Javascript? I am not familiar with what the standard usage pattern should be, so thought
I'd check.
* There are some variables like {{ATTACH_DETACH_TRAITS}} and {{SCHEMA_APPEND}} which are the
suffix part of a URL. However, the {{apiHost}} variable is being prepended to them still.
I don't think this is required. Can you please check?
* navigationController.js still harcodes the URLs.
* On a related note to the above, I notice that the caching of traits is not working anymore
with this patch. That is, the call to {{/api/atlas/types?type=TRAIT}} is being repeated multiple
times even when there is no change in tags.
* Minor: {{SCHEMA_LINEAGE_PREPAND}} should be {{SCHEMA_LINEAGE_PREPEND}} (typo in PREPREND)

> UI. Config file conatining UI: API endpoint + all api calls to be centralized -- config
JS file for stand alone
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: ATLAS-318
>                 URL: https://issues.apache.org/jira/browse/ATLAS-318
>             Project: Atlas
>          Issue Type: Task
>            Reporter: roshni gadiyar
>            Assignee: Darshan Kumar
>            Priority: Minor
>              Labels: Atlas-UI
>         Attachments: ATLAS-318.patch
>
>
> Config file conatining API endpoint + all api calls to be centralized -- config JS file
for stand alone UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message