Return-Path: X-Original-To: apmail-atlas-dev-archive@minotaur.apache.org Delivered-To: apmail-atlas-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CE76918D54 for ; Tue, 22 Dec 2015 12:00:53 +0000 (UTC) Received: (qmail 49222 invoked by uid 500); 22 Dec 2015 12:00:53 -0000 Delivered-To: apmail-atlas-dev-archive@atlas.apache.org Received: (qmail 49177 invoked by uid 500); 22 Dec 2015 12:00:53 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 49166 invoked by uid 99); 22 Dec 2015 12:00:53 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Dec 2015 12:00:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 45AA6C0185 for ; Tue, 22 Dec 2015 12:00:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.226 X-Spam-Level: * X-Spam-Status: No, score=1.226 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qMBCZBYPI6wJ for ; Tue, 22 Dec 2015 12:00:52 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 122EF203BF for ; Tue, 22 Dec 2015 12:00:51 +0000 (UTC) Received: (qmail 48779 invoked by uid 99); 22 Dec 2015 12:00:51 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Dec 2015 12:00:51 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1D24F2C1F5D for ; Tue, 22 Dec 2015 12:00:51 +0000 (UTC) Date: Tue, 22 Dec 2015 12:00:51 +0000 (UTC) From: "Shwetha G S (JIRA)" To: dev@atlas.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ATLAS-106) Store createTimestamp and modified timestamp separately for an entity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ATLAS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068017#comment-15068017 ] Shwetha G S commented on ATLAS-106: ----------------------------------- {code} - public static final String TIMESTAMP_PROPERTY_KEY = INTERNAL_PROPERTY_KEY_PREFIX + "timestamp"; + public static final String CREATION_TIMESTAMP_PROPERTY_KEY = INTERNAL_PROPERTY_KEY_PREFIX + "creationTimestamp"; {code} Can you keep the create time variable as is for backward compatibility? In TypedInstanceToGraphMapper.addOrUpdateAttributesAndTraits(), updating modified time should be done only if the operation is update We use https://reviews.apache.org/dashboard/ for bigger patches as its easier to add comment and track updates there. Can you create review board request going forward? Thanks for taking up this change > Store createTimestamp and modified timestamp separately for an entity > --------------------------------------------------------------------- > > Key: ATLAS-106 > URL: https://issues.apache.org/jira/browse/ATLAS-106 > Project: Atlas > Issue Type: Improvement > Reporter: Suma Shivaprasad > Assignee: David Kantor > Attachments: ATLAS-106-v6.patch > > > Currently we store only the Create timestamp in atlas. Would be better to separate to track create and modified time separately , in cases where we want to support search queries give all entities which have been modified in the past 1 day etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)