atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-300) Need additional integration test coverage for entity notifications
Date Fri, 13 Nov 2015 19:17:11 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004539#comment-15004539
] 

Tom Beerbower commented on ATLAS-300:
-------------------------------------

[~shwethags],

Thanks for the review.

{quote}
1. notificationConsumer.reset(); - add to before test method
{quote}
Added in {{@BeforeMethod}}

{quote}
2. helper methods to make API calls - use AtlasClient instead
{quote}
I changed the test to use AtlasClient for the entity create.  It looks like AtlasClient doesn't
expose a method for add/delete trait.

{quote}
3. Please use 4 spaces for formatting. Can you fix EntityNotificationImplTest, EntityNotificationIT
and any other classes from last patch with 2 spaces
{quote}
Done.

{quote}
4. Can you modify testAddTrait to use super types and also test getAllTraits()
{quote}
Yes, done.

{quote}
For the updated patch, can you add it to review board. Thanks
{quote}
https://reviews.apache.org/r/40308/

> Need additional integration test coverage for entity notifications
> ------------------------------------------------------------------
>
>                 Key: ATLAS-300
>                 URL: https://issues.apache.org/jira/browse/ATLAS-300
>             Project: Atlas
>          Issue Type: Task
>            Reporter: Tom Beerbower
>            Assignee: Tom Beerbower
>
> Add tests for other operations - entity update, trait add/delete. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message