atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-300) Need additional integration test coverage for entity notifications
Date Fri, 13 Nov 2015 06:15:10 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003602#comment-15003602
] 

Shwetha G S commented on ATLAS-300:
-----------------------------------

1. notificationConsumer.reset(); - add to before test method
2. helper methods to make API calls - use AtlasClient instead
3. Please use 4 spaces for formatting. Can you fix EntityNotificationImplTest, EntityNotificationIT
and any other classes from last patch with 2 spaces
4. Can you modify testAddTrait to use super types and also test getAllTraits()

For the updated patch, can you add it to review board. Thanks


> Need additional integration test coverage for entity notifications
> ------------------------------------------------------------------
>
>                 Key: ATLAS-300
>                 URL: https://issues.apache.org/jira/browse/ATLAS-300
>             Project: Atlas
>          Issue Type: Task
>            Reporter: Tom Beerbower
>            Assignee: Tom Beerbower
>         Attachments: ATLAS-300.patch
>
>
> Add tests for other operations - entity update, trait add/delete. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message