Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Subject: Re: Some code questions
MIME-Version: 1.0
From: Shwetha Shivalingamurthy <sshivalingamurthy@hortonworks.com>
To: "dev@atlas.incubator.apache.org" <dev@atlas.incubator.apache.org>
Thread-Topic: Some code questions
Thread-Index: AQHQ5H1fwsD1FJfIik+PvdrYxbSEmZ4oBmuA
Date: Tue, 1 Sep 2015 06:24:59 +0000
Message-ID: <D20B41B2.9AE0%sshivalingamurthy@hortonworks.com>
References: <5453dfe9.890c.14f8789e8f2.Coremail.ltfxyz@163.com>
In-Reply-To: <5453dfe9.890c.14f8789e8f2.Coremail.ltfxyz@163.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D2FC5B2128855C4F93AEFEAB30354A50@exch080.serverpod.net>
Content-Transfer-Encoding: quoted-printable

1, 2 and 4 look like valid issues. Can you file a bug and submit the
patches. Thanks

AttributeStores is used in some tests. Memory based repository is not
used. But can be fixed


Regards,
Shwetha


On 01/09/15 11:43 am, "ltf" <ltfxyz@163.com> wrote:

>Hello,
>I'm very new to Atlas, and I still in the status of learning.
>When I browsed the source code of Atlas, I have the following 4
>questions, maybe or maybe not issues, thanks.
>
>
>1.
>file :=20
>incubator-atlas\typesystem\src\main\java\org\apache\atlas\typesystem\types
>\ObjectGraphTraversal.java
>line : 56
>    void processValue(IDataType dT, Object val) throws AtlasException {
>        if (val !=3D null) {
>            if (dT.getTypeCategory() =3D=3D DataTypes.TypeCategory.ARRAY) =
{
>                IDataType elemType =3D ((DataTypes.ArrayType)
>dT).getElemType();
>                processCollection(elemType, val);
>            } else if (dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.MAP) {
>                IDataType keyType =3D ((DataTypes.MapType) dT).getKeyType(=
);
>                IDataType valueType =3D ((DataTypes.MapType)
>dT).getKeyType();    //   should be getValueType();     ???
>                processMap(keyType, valueType, val);
>            } else if (dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.STRUCT
>                    || dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.TRAIT) {
>                processStruct(val);
>            } else if (dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.CLASS) {
>                processReferenceableInstance(val);
>            }
>        }
>    }
>
>
>2.=20
>file :=20
>incubator-atlas\typesystem\src\main\java\org\apache\atlas\typesystem\types
>\ObjectGraphWalker.java
>line : 94
>    void traverseValue(IDataType dT, Object val) throws AtlasException {
>        if (val !=3D null) {
>            if (dT.getTypeCategory() =3D=3D DataTypes.TypeCategory.ARRAY) =
{
>                IDataType elemType =3D ((DataTypes.ArrayType)
>dT).getElemType();
>                visitCollection(elemType, val);
>            } else if (dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.MAP) {
>                IDataType keyType =3D ((DataTypes.MapType) dT).getKeyType(=
);
>                IDataType valueType =3D ((DataTypes.MapType)
>dT).getKeyType();    //   should be getValueType();     ???
>                visitMap(keyType, valueType, val);
>            } else if (dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.STRUCT
>                    || dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.TRAIT) {
>                visitStruct(val);
>            } else if (dT.getTypeCategory() =3D=3D
>DataTypes.TypeCategory.CLASS) {
>                visitReferenceableInstance(val);
>            }
>        }
>    }
>
>
>3.
>file :=20
>incubator-atlas\repository\src\main\java\org\apache\atlas\repository\memor
>y\AttributeStores.java
>line : 58
>    static IAttributeStore createStore(AttributeInfo i) throws
>RepositoryException {
>        switch (i.dataType().getTypeCategory()) {
>        case PRIMITIVE:
>            if (i.dataType() =3D=3D DataTypes.BOOLEAN_TYPE) {
>                return new BooleanAttributeStore(i);
>            } else if (i.dataType() =3D=3D DataTypes.BYTE_TYPE) {
>                return new ByteAttributeStore(i);
>            } else if (i.dataType() =3D=3D DataTypes.SHORT_TYPE) {
>                new ShortAttributeStore(i);
>                   //   should be return     ???
>            } else if (i.dataType() =3D=3D DataTypes.INT_TYPE) {
>                return new IntAttributeStore(i);
>
>
>4.
>file : incubator-atlas\src\test\python\scripts\TestMetadata.py
>line : 52
>    self.assertTrue(java_mock.called)
>    if IS_WINDOWS:
>      java_mock.assert_called_with(
>        'org.apache.atlas.Main',
>        ['-app', 'metadata_home/server/webapp/atlas'],
>           //  when os is WINDOWS, '/' should be '\\', otherwise the test
>fails, build will stop!!!
>       =20
>'metadata_home/conf:metadata_home/server/webapp/atlas/WEB-INF/classes:meta
>data_home/server/webapp/atlas/WEB-INF/lib\\*:metadata_home/libext\\*',
>        ['-Datlas.log.dir=3Dmetadata_home/logs',
>'-Datlas.log.file=3Dapplication.log', '-Datlas.home=3Dmetadata_home',
>'-Datlas.conf=3Dmetadata_home/conf', '-Xmx1024m',
>'-Dlog4j.configuration=3Datlas-log4j.xml'], 'metadata_home/logs')
>    else:
>
>
>Best, liutongfeng